Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable isort for base directory #26085

Merged
merged 3 commits into from
Jun 24, 2022
Merged

Enable isort for base directory #26085

merged 3 commits into from
Jun 24, 2022

Conversation

clarng
Copy link
Contributor

@clarng clarng commented Jun 24, 2022

Why are these changes needed?

Remove base dir : 'python/ray/*.py' from the isort blacklist. This is needed so it will run isort on subdirectories under python/ray, and allow us to start enabling isort for subdirectories

Related issue number

#25678

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • [] Release tests
    • [] This PR is not tested :(

@clarng clarng requested review from ericl and scv119 June 24, 2022 18:52
@clarng clarng marked this pull request as ready for review June 24, 2022 18:53
@clarng
Copy link
Contributor Author

clarng commented Jun 24, 2022

@ericl can we get a stamp?

@scv119 scv119 merged commit f7d0ad3 into master Jun 24, 2022
@scv119 scv119 deleted the isortcore branch June 24, 2022 22:32
@scv119 scv119 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 24, 2022
truelegion47 pushed a commit to truelegion47/ray that referenced this pull request Jun 30, 2022
* master: (35 commits)
  [tune/structure] Refactor `suggest` into `search` package (ray-project#26074)
  Add back ray.state in deprecation wrapper; print stack trace on warning (ray-project#26086)
  Enable isort for base directory (ray-project#26085)
  [AIR] Add __init__.py to ray.air.callbacks (ray-project#26088)
  [Serve] [Docs] Create end-to-end documentation example for Serve REST API and CLI (ray-project#25936)
  [AIR] Remove unnecessary pandas from examples (ray-project#26009)
  [Datasets] [Hotfix] Update `ds.to_pandas()` limit error to reflect current limit API (ray-project#26081)
  [Serve] [Docs] Add Serve REST API Schema to Serve API Docs (ray-project#25786)
  [Core][Doc] remove cython section from advanced doc. ray-project#26062
  [Core] Fix check failure from incorrect death cause (ray-project#26007)
  [hotfix] Fix linkcheck (ray-project#26070)
  [RLlib] Add timeout to filter synchronization. (ray-project#25959)
  [tune/structure] Introduce logger package (ray-project#26049)
  [RLlib] introduce serialization for our custom gym space types. (ray-project#25923)
  Fix unit test test_check_env.py and est_check_multi_agent.py. (ray-project#25993)
  [RLlib] Make QMix use the ReplayBufferAPI (ray-project#25560)
  [CI] deflake test_multi_node_3 by increasing its timeout
  [CI] Use BUILDKITE_JOB_ID for better navigation for flaky tracker (ray-project#26021)
  [AIR/Docs] Improve user guide gallery (ray-project#26016)
  🎨 Update type annotations to include options in `ray.remote()` (ray-project#25999)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants