Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Update rolling logging configuration #17741

Merged
merged 1 commit into from
Aug 12, 2021
Merged

[Java] Update rolling logging configuration #17741

merged 1 commit into from
Aug 12, 2021

Conversation

kfstorm
Copy link
Member

@kfstorm kfstorm commented Aug 11, 2021

Why are these changes needed?

  • Allow setting env variables RAY_ROTATION_MAX_BYTES and RAY_ROTATION_BACKUP_COUNT to overwrite default values in Java logging configuration (like Python and C++ logging).
  • Fix a bug that Java logging configuration ignores ray.logging.max-backup-files.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kfstorm kfstorm requested a review from jovany-wang August 11, 2021 09:47
@jovany-wang
Copy link
Contributor

Windows failure unrelated.

@jovany-wang jovany-wang merged commit ab53c5f into ray-project:master Aug 12, 2021
@jovany-wang jovany-wang deleted the java_rolling_config_update branch August 12, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovany-wang jovany-wang jovany-wang approved these changes

Assignees

@jovany-wang jovany-wang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kfstorm @jovany-wang