Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip raylet kill windows #17682 #17683

Merged
merged 4 commits into from
Aug 12, 2021

Conversation

rkooo567
Copy link
Contributor

@rkooo567 rkooo567 commented Aug 9, 2021

Why are these changes needed?

Debugging before skipping

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 changed the title [WIP] Skip raylet kill windows #17682 Skip raylet kill windows #17682 Aug 11, 2021
@rkooo567
Copy link
Contributor Author

cc @wuisawesome

@wuisawesome wuisawesome merged commit 8fd7e02 into ray-project:master Aug 12, 2021
Bam4d pushed a commit to Bam4d/ray that referenced this pull request Aug 13, 2021
* Try fixing it?

* Done

* skip raylet signal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants