Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][compiled graphs] Support NCCL operations in non-compiled graphs #48272

Open
stephanie-wang opened this issue Oct 25, 2024 · 2 comments
Open
Labels
compiled-graphs core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability good first issue Great starter issue for someone just starting to contribute to Ray P1 Issue that should be fixed within a few weeks

Comments

@stephanie-wang
Copy link
Contributor

Description

Currently the TorchTensorType(transport="nccl") hint only changes behavior for compiled graphs. Non-compiled graphs cannot execute p2p or allreduce NCCL operations. The performance would be much worse, but we support this feature for debugging purposes.

Use case

No response

@stephanie-wang stephanie-wang added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) compiled-graphs good first issue Great starter issue for someone just starting to contribute to Ray core Issues that should be addressed in Ray Core labels Oct 25, 2024
@gitlijian
Copy link

gitlijian commented Nov 2, 2024

Hello Stephanie Wang, this is my first time working on the Ray open source project, and I really wanted to make some contributions to Ray at that time. I have read your description and hope that non compiled graphics can also support NCCL operations. Since compiled graphics can support NCCL operations, should I follow the relevant NCCL process for compiled graphics to make non compiled graphics support NCCL? Can you describe in more detail how to do it? thank you. @stephanie-wang

@jcotant1 jcotant1 added core Issues that should be addressed in Ray Core and removed core Issues that should be addressed in Ray Core labels Nov 8, 2024
@jjyao jjyao added P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 18, 2024
@Belyenochi
Copy link

Hi @stephanie-wang , is there any progress on this feature? If no one else is following up, can you assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiled-graphs core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability good first issue Great starter issue for someone just starting to contribute to Ray P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

5 participants