Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Post Ray 2.2.0 Release] Update Ray versions to Ray 2.2.0 #822

Merged
merged 4 commits into from
Dec 14, 2022
Merged

[Post Ray 2.2.0 Release] Update Ray versions to Ray 2.2.0 #822

merged 4 commits into from
Dec 14, 2022

Conversation

DmitriGekhtman
Copy link
Collaborator

Signed-off-by: Dmitri Gekhtman dmitri.m.gekhtman@gmail.com

Why are these changes needed?

This PR updates Ray versions to Ray 2.2.0.
It should be merged after the Ray 2.2.0 release.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@DmitriGekhtman
Update Ray versions
d7eb627 
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
kevin85421
kevin85421 approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 26 files with changes look good to me, but I did not check whether all related files are updated.

@DmitriGekhtman
Copy link
Collaborator Author

The 26 files with changes look good to me, but I did not check whether all related files are updated.

I did my best with grep.
If anything is missing, we can fix it later.

@kevin85421
Copy link
Member

I did my best with grep. If anything is missing, we can fix it later.

SGTM

@xwjiang2010
Copy link

Hey folks, ray 2.2.0 release is out. The PR is unblocked to be merged if it's ready.

@DmitriGekhtman
Copy link
Collaborator Author

Hey folks, ray 2.2.0 release is out. The PR is unblocked to be merged if it's ready.

Thanks for the update!

DmitriGekhtman
DmitriGekhtman commented Dec 14, 2022
View reviewed changes
.github/workflows/test-job.yaml

- uses: ./.github/workflows/actions/compatibility
with:
ray_version: 2.2.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin85421 @architkulkarni @sihanwang41 @wilsonwang371 @Jeffwan
I recommend testing compatibility of the last three 2.x.x releases and the last 1.x.x.
So I've added 2.2 without removing 1.13.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommended noting the need to update this compatibility matrix in the Anyscale-internal Ray release instructions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I've added the note in the instructions and linked to this thread.

@DmitriGekhtman
Copy link
Collaborator Author

I've resolved conflicts. This should be fine to merge after the CI finishes.

@DmitriGekhtman DmitriGekhtman merged commit c83b1bd into ray-project:master Dec 14, 2022
@cadedaniel cadedaniel mentioned this pull request Feb 23, 2023
Merged
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@DmitriGekhtman
[Post Ray 2.2.0 Release] Update Ray versions to Ray 2.2.0 (ray-projec…
62b3078 
…t#822)

Update Ray versions to 2.2.0

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

@Jeffwan Jeffwan Jeffwan approved these changes

@architkulkarni architkulkarni Awaiting requested review from architkulkarni

@sihanwang41 sihanwang41 Awaiting requested review from sihanwang41

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DmitriGekhtman @kevin85421 @xwjiang2010 @Jeffwan @architkulkarni