Improve RayJob controller quality to alpha #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
force-pushed
the
jiaxin/rayjob_improvement
branch
4 times, most recently
from
7869665 to
1e4a9b6
Compare
Jeffwan
changed the title
Jeffwan
force-pushed
the
jiaxin/rayjob_improvement
branch
4 times, most recently
from
5741479 to
86b1d53
Compare
|
/cc @harryge00 Please have a check. I make some improvements on the RayJob |
4 tasks
1. Implement `spec.shutdownAfterJobFinishes`, delete the cluster once the job finishes if this field is set 2. Add status new field `JobDeploymentStatusComplete` to indicate the RayJob is complete 3. Add status field `Message`, `StartTime`, `EndTime` to expose more job status 4. Improve logs usage in the operators and make them look consistent 5. Optimize requeueAfter for some time consuming operators like waiting for dashboard ready (container takes time to start) etc.
Jeffwan
force-pushed
the
jiaxin/rayjob_improvement
branch
from
86b1d53 to
f93158d
Compare
harryge00
reviewed
Jul 26, 2022
harryge00
approved these changes
Jul 26, 2022
|
Let me merge the PR. I test it in our env and currently it's working fine. If you guys have additional comments. Let me know and I will address it in separate PR |
2 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
1. Implement `spec.shutdownAfterJobFinishes`, delete the cluster once the job finishes if this field is set 2. Add status new field `JobDeploymentStatusComplete` to indicate the RayJob is complete 3. Add status field `Message`, `StartTime`, `EndTime` to expose more job status 4. Improve logs usage in the operators and make them look consistent 5. Optimize requeueAfter for some time consuming operators like waiting for dashboard ready (container takes time to start) etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fix RayJob controller issues and few enhancements.
spec.shutdownAfterJobFinishes, delete the cluster once the job finishes if this field is setJobDeploymentStatusCompleteto indicate the RayJob is completeMessage,StartTime,EndTimeto expose more job statusRelated issue number
#393
Checks