fix: use configured RayCluster service account when autoscaling #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Jeffwan
reviewed
May 12, 2022
davidxia
force-pushed
the
patch1
branch
2 times, most recently
from
afdee67 to
4aa4af1
Compare
davidxia
commented
May 12, 2022
davidxia
commented
May 12, 2022
davidxia
force-pushed
the
patch1
branch
3 times, most recently
from
64a8b35 to
b22feeb
Compare
|
This is ready for review now |
Jeffwan
reviewed
May 12, 2022
|
The change looks good to me and please help move test to _test.go. Thanks! @davidxia |
|
@Jeffwan lmk next steps if any that are required for merging this. Thanks! 🙏 |
Jeffwan
approved these changes
May 18, 2022
|
Thanks for the contribution! |
davidxia
added a commit
to davidxia/kuberay
that referenced
this pull request
May 25, 2022
Currently the patch in ray-project#259 isn't working because a later line overwrites with the original bad value. This change sets the head pod's service account to the one configured in the RayCluster.
4 tasks
davidxia
added a commit
to davidxia/kuberay
that referenced
this pull request
May 26, 2022
Currently the patch in ray-project#259 isn't working because a later line overwrites with the original bad value. This change sets the head pod's service account to the one configured in the RayCluster.
davidxia
added a commit
to davidxia/kuberay
that referenced
this pull request
Jun 6, 2022
Currently the patch in ray-project#259 isn't working because a later line overwrites with the original bad value. This change sets the head pod's service account to the one configured in the RayCluster.
Jeffwan
pushed a commit
that referenced
this pull request
Jun 8, 2022
Currently the patch in #259 isn't working because a later line overwrites with the original bad value. This change sets the head pod's service account to the one configured in the RayCluster.
davidxia
added a commit
to davidxia/kuberay
that referenced
this pull request
Jun 19, 2022
instead of always using RayCluster name. Default to RayCluster name if the ServiceAccount doesn't exist. This is a follow up fix after ray-project#259 and ray-project#276. The use case is when using the RayCluster autoscaler. The autoscaler will use the head group's K8s ServiceAccount to make K8s API requests. Always using the RayCluster name as the RoleBinding's subject name won't be correct and will result in the autoscaler sidecar container not being authorized by the K8s API.
4 tasks
DmitriGekhtman
pushed a commit
that referenced
this pull request
Jun 21, 2022
instead of always using RayCluster name. Default to RayCluster name if the ServiceAccount doesn't exist. This is a follow up fix after #259 and #276. The use case is when using the RayCluster autoscaler. The autoscaler will use the head group's K8s ServiceAccount to make K8s API requests. Always using the RayCluster name as the RoleBinding's subject name won't be correct and will result in the autoscaler sidecar container not being authorized by the K8s API.
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Currently the patch in ray-project#259 isn't working because a later line overwrites with the original bad value. This change sets the head pod's service account to the one configured in the RayCluster.
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…roject#315) instead of always using RayCluster name. Default to RayCluster name if the ServiceAccount doesn't exist. This is a follow up fix after ray-project#259 and ray-project#276. The use case is when using the RayCluster autoscaler. The autoscaler will use the head group's K8s ServiceAccount to make K8s API requests. Always using the RayCluster name as the RoleBinding's subject name won't be correct and will result in the autoscaler sidecar container not being authorized by the K8s API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue number
closes #242
Checks