forked from freeCodeCamp/freeCodeCamp
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge #4
Merged
Merged
Merge #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Renovate Bot <bot@renovateapp.com>
…3349) * rename: i18n rdbms challenge files * fix: adjust frontmatter to match
chore(i18n,docs): processed translations
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* fix: replace responsive web dev bitly links * Revert "fix: replace responsive web dev bitly links" This reverts commit 3d2bcbe. * fix: remove video url from html challenges using old image srcs
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com> Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: require login as step * fix: cert rendering temporary * fix: remove keys from other translation files * fix: cypress test * chore: shauns suggestions * fix: remove steps * fix: use a seperate UseEffect function * Suggestions from Shaun Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> * fix: certification temp rendering * fix: cert temp rendering hopefully * fix: button visibility and cert test * fix: condition * test: improve claim cert tests Without npm run seed, retries will be in a different state. Check the scroll position to (hopefully) catch the weird cert claim bug. Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
…e numbers, n, which are also square" (#43647)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
react-monaco-editor depends on specific monaco-editor versions, so this makes sure they're all updated in the same renovate PR
* feat: dispatch resetChallenge action * fix: copy challengeFiles instead of in-place sort * fix: handle null updateFile payloads in redux * refactor: reorganise region initialization * refactor: pull code into editorDidMount Then we can rely on the presence of the editor and monaco and don't have litter the code with null checks. * refactor: use better name for editable region init * refactor: remove unused decoration * refactor: rename forbidden region init functions * fix: keep all challengeFiles when resetting * refactor: remove unused decoration class * fix: reinitialize editor on reset * fix: stop adding multiple scroll listeners Since the challengeFile update on each keystroke extra (unnecessary) adding of listeners slowed the editor to a crawl. * fix: only scroll to editor on mount Rather than on any edit. * refactor: remove logs and comments * fix: rename toSortedArray and fix broken test * fix: check for null not falsy in updateFile * fix: only update project features when project * fix: only reset if editor contents have changed * feat: focus on editor after reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md
)master
branch of freeCodeCamp.Closes #XXXXX