Creating Brazilian Portuguese version of resource files. #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no resource files for DownloadUpdateDialog and RemindLaterForm. Does translation for them is decent and it doesn't require it? |
|
I didn't notice those files. I will do their translation and commit again. This is my first pull request ever, how shall I proceed? |
|
I think you can commit new files and it will show up in the pull request. |
…emindLaterForm. Also did a small correction on European Portuguese translation for RemindLaterForm.
ravibpatel
requested changes
Jan 25, 2020
| <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value> | ||
| </resheader> | ||
| <assembly alias="System.Windows.Forms" name="System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" /> | ||
| <data name="clock_go" type="System.Resources.ResXFileRef, System.Windows.Forms"> |
There was a problem hiding this comment.
Please remove duplicate resource entries like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite Brazilian Portuguese and European Portuguese being mutually inteligible the way native speakers express themselves is different.
The current Portuguesse translation sounds awkard to Brazilian natives, this is why I decided to contribute with the project.