Fix postMessage({}, '*') causes slackin to throw #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-slackin code may postMessage() to the same window (in my case, a Twitter button), and unlike slackin, may choose to send an object as a message rather than a string. Unlike strings, not all objects have a .substr() method, so slackin doing e.data.substr() throws an exception: https://git.io/v2N5t
Two instances of 'null == {whatever}' in lib/assets/superagent.js left
untouched:
$ git grep ' == '
lib/assets/superagent.js: if (null == resolved) {
lib/assets/superagent.js: if (null == this.header[field]) continue;
scripts/azuredeploy.sh:if [[ "$SLACKIN_RELEASE" == "stable" ]]; then
rauchg
added a commit
that referenced
this pull request
Mar 8, 2016
Fix postMessage({}, '*') causes slackin to throw
|
@laughinghan you're on 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-slackin code may postMessage() to the same window (in my case, a
Twitter button), and unlike slackin, may choose to send an object as a
message rather than a string. Unlike strings, not all objects have a
.substr() method, so slackin doing e.data.substr() throws an exception: