Add "or sign in" link to iframe too #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why was it excluded in rauchg#80? With the button that opens the iframe dialog, there's no link to the landing page, which means with the button there's no link at all to the actual Slack channel.
This was referenced Feb 27, 2016
laughinghan
added a commit
to laughinghan/slackin
that referenced
this pull request
Mar 2, 2016
Open PR into mainline: rauchg#153
laughinghan
added a commit
to laughinghan/slackin
that referenced
this pull request
Mar 2, 2016
Conflicts with rauchg#153 feature.sign-in-link-in-iframe: lib/index.js Added `large` param to splash() call, to which rauchg#153 had added `org` lib/splash.js Converted px to rem where rauchg#153 had removed iframe branch and dedented
rauchg
added a commit
that referenced
this pull request
Mar 4, 2016
Add "or sign in" link to iframe too
laughinghan
added a commit
to laughinghan/slackin
that referenced
this pull request
Mar 5, 2016
Conflicts with rauchg#153 feature.sign-in-link-in-iframe: lib/index.js Added `large` param to splash() call, to which rauchg#153 had added `org` lib/splash.js Converted px to rem where rauchg#153 had dedented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was it excluded in #80? With the button that opens the iframe
dialog, there's no link to the landing page, which means with the button
there's no link at all to the actual Slack channel.