Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup position in firefox #182

Closed
crobinson42 opened this issue Apr 9, 2016 · 9 comments · Fixed by #226
Closed

Popup position in firefox #182

crobinson42 opened this issue Apr 9, 2016 · 9 comments · Fixed by #226

Comments

@crobinson42
Copy link
Contributor

I'm experiencing an issue with the popup rendering at the top of the page when the snippet and iframe for slackin is located at the bottom of the page.

This issue is only experienced in Firefox.
@laughinghan
Copy link
Contributor

Screenshot? Browser version? OS? User-agent string?

@laughinghan
Copy link
Contributor

also, Slackin version?

@crobinson42
Copy link
Contributor Author

You can view it with Firefox at www.therms.io
On Apr 11, 2016 12:18, "Han Seoul-Oh" notifications@github.com wrote:

also, Slackin version?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#182 (comment)

@crobinson42
Copy link
Contributor Author

@laughinghan any thoughts?

@crobinson42
Copy link
Contributor Author

crobinson42 commented Apr 26, 2016 •
edited
Loading

Gif recording: http://recordit.co/beDRvESpMK/gif/notify

egid pushed a commit to egid/slackin that referenced this issue Aug 12, 2016
update from document.body to document.documentElement for Firefox com…
6b29520 
…patibility. fixes rauchg#182.
@egid
Copy link
Contributor

egid commented Aug 12, 2016

The issue here is that document.body.scrollTop isn't supported by Firefox - it always returns 0.

Using document.documentElement.foo works just fine.

@egid egid mentioned this issue Aug 12, 2016
Merged
davidalber pushed a commit to davidalber/slackin that referenced this issue Aug 12, 2016
@davidalber
update from document.body to document.documentElement for Firefox com…
9bfc4f8 
…patibility. fixes rauchg#182.
davidalber pushed a commit to davidalber/slackin that referenced this issue Aug 13, 2016
@davidalber
update from document.body to document.documentElement for Firefox com…
4fb1305 
…patibility. fixes rauchg#182.

document.documentElement is no more cross-browser than .body. Switching to window.scrollY, with a fallback to docbody for IE.
davidalber pushed a commit to davidalber/slackin that referenced this issue Aug 13, 2016
@davidalber
update from document.body to document.documentElement for Firefox com…
6f0f1fb 
…patibility. fixes rauchg#182.

document.documentElement is no more cross-browser than .body. Switching to window.scrollY, with a fallback to docbody for IE.
@crobinson42
Copy link
Contributor Author

I see you added window.scrollY/X - This still doesn't fix the popup. rendering to the stop of the page

@egid
Copy link
Contributor

egid commented Aug 15, 2016

@crobinson42 - interesting. It worked on our install. documentElement had chrome issues, but window.scrollY seemed to work cross-browser.

@crobinson42
Copy link
Contributor Author

I just manually added those 2 lines, maybe I should try a new install. I’ll let you know. Thanks.

rauchg pushed a commit that referenced this issue Oct 22, 2016
@egid @rauchg
Switch from pure document.body for badge flyout Firefox compatibility. (
e0f09a5 
#226)

* update from document.body to document.documentElement for Firefox compatibility. fixes #182.

* document.documentElement is no more cross-browser than .body. Switching to window.scrollY, with a fallback to docbody for IE.
mexisme pushed a commit to devopsnz/slackin that referenced this issue Mar 10, 2017
@egid @mexisme
Switch from pure document.body for badge flyout Firefox compatibility. (
c600d25 
rauchg#226)

* update from document.body to document.documentElement for Firefox compatibility. fixes rauchg#182.

* document.documentElement is no more cross-browser than .body. Switching to window.scrollY, with a fallback to docbody for IE.
mexisme pushed a commit to devopsnz/slackin that referenced this issue Mar 10, 2017
@egid @mexisme
Switch from pure document.body for badge flyout Firefox compatibility. (
e4f6e8d 
rauchg#226)

* update from document.body to document.documentElement for Firefox compatibility. fixes rauchg#182.

* document.documentElement is no more cross-browser than .body. Switching to window.scrollY, with a fallback to docbody for IE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from pure document.body for badge flyout Firefox compatibility. egid/slackin
3 participants
@laughinghan @egid @crobinson42