feat: add an impl of DoubleEndedIterator for Columns and Rows (#1357)
#1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1358 +/- ##
=====================================
Coverage 94.0% 94.1%
=====================================
Files 68 68
Lines 16360 16433 +73
=====================================
+ Hits 15393 15466 +73
Misses 967 967 ☔ View full report in Codecov by Sentry. |
fujiapple852
commented
Sep 7, 2024
joshka
approved these changes
Sep 7, 2024
fujiapple852
force-pushed
the
feat-columns-double-ended-iter
branch
from
b0e69c0 to
8bb01ac
Compare
|
Added |
fujiapple852
changed the title
DoubleEndedIterator for Columns (#1357)DoubleEndedIterator for Columns and Rows (#1357)
joshka
approved these changes
Sep 8, 2024
fujiapple852
force-pushed
the
feat-columns-double-ended-iter
branch
from
8bb01ac to
73aa535
Compare
orhun
approved these changes
Sep 20, 2024
joshka
force-pushed
the
feat-columns-double-ended-iter
branch
from
73aa535 to
4680e6e
Compare
joshka
approved these changes
Oct 14, 2024
joshka
pushed a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
…atatui#1358) BREAKING-CHANGE: The `pub` modifier has been removed from fields on the `layout::rect::Columns` and `layout::rect::Rows` iterators. These fields were not intended to be public and should not have been accessed directly. Fixes: ratatui#1357
kdheepak
added a commit
that referenced
this pull request
Oct 16, 2024
* origin/main: (21 commits) perf: implement size hints for `Rect` iterators (#1420) fix(color): fix doc test for from_hsl (#1421) docs: tweak readme (#1419) refactor(color)!: use palette types for Hsl/Hsluv conversions (#1418) chore(deps)!: pin unicode-width to 0.2.0 (#1403) feat(scrolling-regions)!: use terminal scrolling regions to stop Terminal::insert_before from flickering (#1341) feat!: add an impl of `DoubleEndedIterator` for `Columns` and `Rows` (#1358) fix(rect)!: Rect::area now returns u32 and Rect::new() no longer clamps area to u16::MAX (#1378) docs: fix missing breaking changes link (#1416) feat(line)!: impl From<Cow<str>> for Line (#1373) chore(deny): allow Zlib license in cargo-deny configuration (#1411) feat(tabs)!: allow tabs to be deselected (#1413) feat(color): add hsluv support (#1333) feat(table)!: add support for selecting column and cell (#1331) feat(text): improve concise debug view for Span,Line,Text,Style (#1410) chore: add benchmark for `Table` (#1408) refactor: Consistent result expected in layout tests (#1406) feat(logo): Add a Ratatui logo widget chore(deps): update rstest requirement from 0.22.0 to 0.23.0 (#1394) chore(deps): update octocrab requirement from 0.40.0 to 0.41.0 (#1393) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1357