Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frame): introduce .area() as its more correct than .size() #1293

Merged
merged 2 commits into from
Aug 6, 2024
Merged

feat(frame): introduce .area() as its more correct than .size() #1293

merged 2 commits into from
Aug 6, 2024

Conversation

EdJoPaTo
Copy link
Contributor

@EdJoPaTo EdJoPaTo commented Aug 5, 2024

@EdJoPaTo EdJoPaTo requested a review from a team as a code owner August 5, 2024 08:33
@codecov Codecov
Copy link

codecov bot commented Aug 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.5%. Comparing base (6e7b4e4) to head (d3cae31).

Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #1293     +/-   ##
=======================================
- Coverage   94.5%   94.5%   -0.1%     
=======================================
  Files         65      65             
  Lines      15440   15425     -15     
=======================================
- Hits       14605   14587     -18     
- Misses       835     838      +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

🐰Bencher

ReportMon, August 5, 2024 at 08:59:11 UTC
ProjectRatatui
Branch1293/merge
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
barchart/render/2048➖ (view plot)177,060.00
barchart/render/256➖ (view plot)107,660.00
barchart/render/64➖ (view plot)69,610.00
barchart/render_grouped/2048➖ (view plot)321,720.00
barchart/render_grouped/256➖ (view plot)119,130.00
barchart/render_grouped/64➖ (view plot)106,810.00
barchart/render_horizontal/2048➖ (view plot)151,400.00
barchart/render_horizontal/256➖ (view plot)69,973.00
barchart/render_horizontal/64➖ (view plot)64,269.00
block/render_all_feature/100x50➖ (view plot)8,795.00
block/render_all_feature/200x50➖ (view plot)15,617.00
block/render_all_feature/256x256➖ (view plot)70,618.00
block/render_empty/100x50➖ (view plot)4,503.00
block/render_empty/200x50➖ (view plot)8,950.50
block/render_empty/256x256➖ (view plot)58,022.00
line_render/Center/0➖ (view plot)2.48
line_render/Center/10➖ (view plot)415.20
line_render/Center/3➖ (view plot)233.45
line_render/Center/4➖ (view plot)254.01
line_render/Center/42➖ (view plot)506.23
line_render/Center/6➖ (view plot)256.56
line_render/Center/7➖ (view plot)287.10
line_render/Left/0➖ (view plot)2.48
line_render/Left/10➖ (view plot)362.19
line_render/Left/3➖ (view plot)144.83
line_render/Left/4➖ (view plot)153.00
line_render/Left/42➖ (view plot)506.00
line_render/Left/6➖ (view plot)234.47
line_render/Left/7➖ (view plot)247.86
line_render/Right/0➖ (view plot)2.48
line_render/Right/10➖ (view plot)376.32
line_render/Right/3➖ (view plot)219.49
line_render/Right/4➖ (view plot)256.77
line_render/Right/42➖ (view plot)505.90
line_render/Right/6➖ (view plot)329.57
line_render/Right/7➖ (view plot)366.83
list/render/16384➖ (view plot)1,145,500.00
list/render/2048➖ (view plot)257,070.00
list/render/64➖ (view plot)133,150.00
list/render_scroll_half/16384➖ (view plot)1,151,600.00
list/render_scroll_half/2048➖ (view plot)257,390.00
list/render_scroll_half/64➖ (view plot)90,516.00
paragraph/new/2048➖ (view plot)248,690.00
paragraph/new/64➖ (view plot)6,036.60
paragraph/new/65535➖ (view plot)14,074,000.00
paragraph/render/2048➖ (view plot)430,750.00
paragraph/render/64➖ (view plot)389,960.00
paragraph/render/65535➖ (view plot)1,498,200.00
paragraph/render_scroll_full/2048➖ (view plot)387,670.00
paragraph/render_scroll_full/64➖ (view plot)408,010.00
paragraph/render_scroll_full/65535➖ (view plot)1,473,200.00
paragraph/render_scroll_half/2048➖ (view plot)385,960.00
paragraph/render_scroll_half/64➖ (view plot)413,960.00
paragraph/render_scroll_half/65535➖ (view plot)1,465,600.00
paragraph/render_wrap/2048➖ (view plot)222,130.00
paragraph/render_wrap/64➖ (view plot)187,480.00
paragraph/render_wrap/65535➖ (view plot)1,415,000.00
paragraph/render_wrap_scroll_full/2048➖ (view plot)220,290.00
paragraph/render_wrap_scroll_full/64➖ (view plot)187,700.00
paragraph/render_wrap_scroll_full/65535➖ (view plot)1,405,900.00
sparkline/render/2048➖ (view plot)111,900.00
sparkline/render/256➖ (view plot)111,750.00
sparkline/render/64➖ (view plot)35,277.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@joshka joshka merged commit f97e07c into ratatui:main Aug 6, 2024
38 checks passed
@EdJoPaTo EdJoPaTo deleted the frame-size-area branch August 6, 2024 06:52
joshka pushed a commit to erak/ratatui that referenced this pull request Oct 14, 2024
@EdJoPaTo @joshka
feat(frame): replace Frame::size() with Frame::area() (ratatui#1293)
0f71dbb 
Area is the more correct term for the result of this method.
The Frame::size() method is marked as deprecated and will be
removed around Ratatui version 0.30 or later.

Fixes: ratatui#1254 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshka joshka joshka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdJoPaTo @joshka