feat(text)!: remove unnecessary lifetime from ToText trait #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The ToText trait no longer has a lifetime parameter. This change simplifies the trait and makes it easier implement.
joshka
requested review from
orhun,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
kdheepak
approved these changes
Jul 22, 2024
|
Oops, I guess I missed this. Thanks for fixing it :) |
|
No probs - it's breaking, but not in a way that is likely to harm anyone significantly. |
|
As I just wondered about it: This is not listed in BREAKING-CHANGES.md as it's a change to a not yet released addition (#1167). Still the automation thinks the next release has to be breaking as it includes this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The ToText trait no longer has a lifetime parameter.
This change simplifies the trait and makes it easier implement.