docs(examples): update tabs example and tabs.tape #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated tabs example and tabs.tape
Emivvvvv
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka,
kdheepak and
Valentin271
as code owners
added documentation comment for SelectedTab::tab_title()
|
There might be ways to further simplify this - let's wait for comments from other devs. |
Valentin271
requested changes
Jan 20, 2024
impl From<SelectedTab> for Line<'_> to get enum names to set them as tab titles.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
=====================================
Coverage 92.5% 92.5%
=====================================
Files 61 61
Lines 16316 16316
=====================================
Hits 15095 15095
Misses 1221 1221 ☔ View full report in Codecov by Sentry. |
orhun
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #846, #819
This PR adds:
for tabs.rs
for tabs.tape
Here is the new output:
