chore: add comment on PRs with unsigned commits #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valentin271
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka and
kdheepak
as code owners
|
Sounds good |
|
Does this need: |
Valentin271
force-pushed
the
chore/comment-unsigned-commit
branch
from
cf53441 to
1165cfe
Compare
If it was missing that I guess the check would have run and failed. Tried anyway but no luck. |
joshka
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes forget to check for commit signature and are only reminded at the time of merging.
We also sometime forget to link to relevant documentation and whatnot.
This adds friction to new contributors and some redundant work for us.
I propose to use this action to post a comment on PRs with unsigned commits. Contributors will be pinged when pushing even if no one is around and can work on that.
Let me know your thoughts and good resources to link in the comment.
I'll put an unsigned commit on this PR so we can see what it looks like (I'll rebase once this is approved).Pipelines take the workflow from main so I guess we'll hope and see ...