refactor: define struct WrappedLine instead of anonymous tuple #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progval
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka and
kdheepak
as code owners
progval
force-pushed
the
wrappedline
branch
2 times, most recently
from
4a719ee to
cc141f9
Compare
This was referenced Nov 2, 2023
joshka
approved these changes
Nov 29, 2023
|
This needs a small update to rebase on the conflicts. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=====================================
Coverage 90.9% 90.9%
=====================================
Files 42 42
Lines 12533 12542 +9
=====================================
+ Hits 11394 11403 +9
Misses 1139 1139 ☔ View full report in Codecov by Sentry. |
joshka
approved these changes
Dec 4, 2023
|
Hey would you mind signing your commit with gpg and force pushing a change with this (and the updates for the conflicts) See |
progval
force-pushed
the
wrappedline
branch
5 times, most recently
from
732ad3c to
9552ec2
Compare
|
Hi, could you run |
It makes the type easier to document, and more obvious for users
|
I rebased instead |
|
Works for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes the type easier to document, and more obvious for users, given that #607 makes this part of the public API