Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify backsplash color correct #5554

Merged
merged 4 commits into from
Mar 4, 2021
Merged

Simplify backsplash color correct #5554

merged 4 commits into from
Mar 4, 2021

Conversation

aaronxsu
Copy link
Member

@aaronxsu aaronxsu commented Mar 3, 2021 •
edited
Loading

Overview

This PR:

  • removes the disableAutoCorrect QP
  • simplifies the color correction logic in backsplash

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible
  • Swagger specification updated
  • New tables and queries have appropriate indices added
  • Any content changes are properly templated using BUILDCONFIG.APP_NAME
  • Any new SQL strings have tests
  • Any new endpoints have scope validation and are included in the integration test csv

Testing Instructions

  • I pushed a /test branch up so staging should reflect the changes in this PR; feel free to push test/asu/simplify-color-correct again in case staging is overwritten
  • Go to GroundWork staging -- make sure the recent images show up just fine
  • Upload the image in question in here in GW and make sure it displays just fine without disabling the auto color correction

Closes https://github.com/azavea/raster-foundry-platform/issues/1202

@aaronxsu aaronxsu requested a review from jisantuc March 4, 2021 00:37
@aaronxsu aaronxsu marked this pull request as ready for review March 4, 2021 00:38
jisantuc
jisantuc approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@jisantuc jisantuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

app-backend/backsplash-core/src/main/scala/com/rasterfoundry/backsplash/BacksplashImage.scala
@@ -52,7 +52,6 @@ final case class BacksplashGeotiff(
mask: Option[MultiPolygon],
footprint: MultiPolygon,
metadata: SceneMetadataFields,
disableAutoCorrect: Option[Boolean],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@aaronxsu aaronxsu merged commit d9a6ca3 into develop Mar 4, 2021
@aaronxsu aaronxsu deleted the feature/asu/simplify-color-correct branch March 4, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jisantuc jisantuc jisantuc approved these changes

Assignees

@jisantuc jisantuc

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronxsu @jisantuc