Update README.md #5544
Merged
Update README.md #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move ensuring directories into bootstrap
kshepard
reviewed
Mar 3, 2021
| - AWS CLI 1.10+ | ||
| - AWS Account (to store artifacts, secrets) | ||
| - [Auth0 Account](https://auth0.com/) (user management) | ||
| - [jabba](https://github.com/shyiko/jabba) for managing Java versions | ||
| - [nvm](https://github.com/nvm-sh/nvm) for managing Node versions |
There was a problem hiding this comment.
Seems like sbt is also a requirement.
There was a problem hiding this comment.
Actually, that may have been a red herring. I think maybe the actual thing I missed is that scripts/update needs to be run from within the app-backend directory. Testing that out now, but if it's true, we probably want to modify scripts/update, so it can be run from the root directory.
There was a problem hiding this comment.
Made it through provisioning with the following change:
--- a/scripts/update
+++ b/scripts/update
@@ -21,8 +21,10 @@ if [ "${BASH_SOURCE[0]}" = "${0}" ]; then
usage
else
echo "Building Scala assembly JARs"
- sbt \
- ";api/assembly;backsplash-server/assembly;batch/assembly;backsplash-export/assembly"
+ pushd "app-backend"
+ sbt \
+ ";api/assembly;backsplash-server/assembly;batch/assembly;backsplash-export/assembly"
+ popd
echo "Running application database migrations"
./scripts/migrate migrate
kshepard
reviewed
Mar 3, 2021
kshepard
approved these changes
Mar 3, 2021
Co-authored-by: Kenny Shepard <kshepard@azavea.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Brief description of what this PR does, and why it is needed.
Checklist
Testing Instructions