Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create one intercom notifier #5510

Merged
merged 6 commits into from
Nov 17, 2020

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Nov 13, 2020

Overview

This PR makes it so that we only ever create a single IntercomNotifier, which does enough to resolve implicits that we don't get a null pointer exception when we share with existing users.

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Notes

hide whitespace changes in review scalafmt got way too excited

There's still some kind of issue with akka-streams and an unsubscribed response entity that I'm working out, but this at least solves the immediate problem of "always error".

I believe this will also require some frontend changes to report the information about which email addresses had unsuccessful shares, but I don't think we know what that should look like or if that's information that we will want that we're not worried about exposing to users. Since the errors were the result of NPEs for existing users only, I don't think there are actually real errors that we needed to report.

An issue is that bad email addresses don't show up as errors -- for example, our SMTP logs show that the server was perfectly happy to pass off the message to the azavea mail server for jsantuc@azavea.com. I'm not sure whether there's anything we can do about that.

Testing Instructions

  • assemble api server
  • bring up servers
  • bring up groundwork
  • go to the sharing tab of a project you're allowed to share
  • put in the email address for a user who exists and share
  • you shouldn't see an error

I don't know how to test the returning-all-errors part aside from trusting the ValidatedNel data type -- changes in eb5a35a

Closes raster-foundry/groundwork#1108

@jisantuc jisantuc merged commit cc0057a into develop Nov 17, 2020
@jisantuc jisantuc deleted the bugfix/js/fix-intercom-interaction-probably branch November 17, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants