Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set upload limit to 10 GiB instead of 1GB #5346

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Set upload limit to 10 GiB instead of 1GB #5346

merged 2 commits into from
Mar 4, 2020

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Mar 4, 2020 •
edited
Loading

Overview

This pr sets the upload creation limit to 10 GiB instead of 1GB (supposed to be 10GB, oops) because it's more consistent with the sizes reported by file systems. It will probably make limit usage more of a nuisance, but for reference, 1 GiB = 2 ^ 30 bytes (it's also expressed that way in the Scope.scala file for easier future reference).

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Testing Instructions

  • check how to calculate GiB
  • man du or du --help to confirm default size reporting

Closes raster-foundry/annotate#705

@jisantuc jisantuc requested a review from Lknechtli March 4, 2020 17:46
@jisantuc jisantuc merged commit e447ba2 into develop Mar 4, 2020
@jisantuc jisantuc deleted the feature/js/set-upload-create-limit-to-10-gib branch March 4, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lknechtli Lknechtli Lknechtli approved these changes

Assignees

@Lknechtli Lknechtli

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jisantuc @Lknechtli