Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scene id to scene detail modal #5168

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Add scene id to scene detail modal #5168

merged 1 commit into from
Sep 13, 2019

Conversation

Lknechtli
Copy link
Contributor

@Lknechtli Lknechtli commented Sep 13, 2019 •
edited
Loading

Overview

Expose scene id in the scene detail modal

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible
  • Swagger specification updated
  • New tables and queries have appropriate indices added
  • Any content changes are properly templated using BUILDCONFIG.APP_NAME
  • Any new SQL strings have tests

Demo

image

Notes

Users shouldn't have to open the network tab of their dev tools to find a scene id.

Testing Instructions

  • View a scene detail modal and verify that the id is visible

@Lknechtli Lknechtli requested a review from alkamin September 13, 2019 17:04
@Lknechtli Lknechtli force-pushed the feature/lk/expose-scene-id-in-ui branch from 12bd3e1 to 04d23a7 Compare September 13, 2019 17:06
@Lknechtli Lknechtli merged commit cff0444 into develop Sep 13, 2019
@Lknechtli Lknechtli deleted the feature/lk/expose-scene-id-in-ui branch September 16, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alkamin alkamin alkamin approved these changes

Assignees

@alkamin alkamin

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lknechtli @alkamin