Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Migrations in Tests + Migration Fixes #4987

Merged
merged 8 commits into from
May 17, 2019
Merged

Run Migrations in Tests + Migration Fixes #4987

merged 8 commits into from
May 17, 2019

Conversation

notthatbreezy
Copy link

@notthatbreezy notthatbreezy commented May 17, 2019 •
edited
Loading

Overview

Adds support for invoking flyway migrations during tests, fixes the initial baseline migration, and adjusts migration container building to be a flyway based docker image with migrations included.

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Testing Instructions

  • Verify that CI passes (it exercises tests and runs migrations from scratch for the test template)

Closes #4946
Closes #4984

@notthatbreezy notthatbreezy changed the title [WIP] Run Migrations in Tests + Migration Fixes Run Migrations in Tests + Migration Fixes May 17, 2019
jisantuc
jisantuc approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@jisantuc jisantuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

👀 🏎️ 🚤

@notthatbreezy notthatbreezy merged commit d24a35b into develop May 17, 2019
@notthatbreezy notthatbreezy deleted the feature/cmb/fix-and-update-migrations branch May 17, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jisantuc jisantuc jisantuc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Running Migrations on Empty Database Update Tests to Use Flyway Migrations
2 participants
@notthatbreezy @jisantuc