Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add owner name and profile URL to the return of annotation GET endpoint #4924

Merged
merged 5 commits into from
May 6, 2019
Merged

Add owner name and profile URL to the return of annotation GET endpoint #4924

merged 5 commits into from
May 6, 2019

Conversation

aaronxsu
Copy link
Member

@aaronxsu aaronxsu commented May 2, 2019 •
edited
Loading

Overview

This PR updates the single annotation GET endpoint so that it includes owner name and profile picture url.

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible
  • Styleguide updated, if necessary
  • Swagger specification updated
  • Symlinks from new migrations present or corrected for any new migrations
  • Any content changes are properly templated using BUILDCONFIG.APP_NAME
  • Any new SQL strings have tests (Updated the test)

Testing Instructions

  • CI for AnnotationDaoSpec should pass
  • Reassemble the api jar
  • Spin up server and frontend
  • Go to a project and create some annotations, grab project ID and one of annotations' ID
  • GET to /api/project/<project ID>/annotations/<annotation ID> should give you owner name and profile url along with annotation info

Closes #4922

@aaronxsu aaronxsu requested a review from alkamin May 2, 2019 17:07
notthatbreezy
notthatbreezy reviewed May 3, 2019
View reviewed changes
docs/swagger/spec.yml
type:
type: string
properties:
allOf:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is missing labeledBy and verifiedBy -- do we need that additional information as well for display purposes in the annotation UI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notthatbreezy good call. I think we need them. They are included in the return. I will add them to the spec as well.

@aaronxsu aaronxsu merged commit dd2bbf5 into develop May 6, 2019
@aaronxsu aaronxsu deleted the feature/asu/return-owner-info-with-annotation branch May 6, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notthatbreezy notthatbreezy notthatbreezy left review comments

@alkamin alkamin alkamin approved these changes

Assignees

@alkamin alkamin

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support withOwnerInfo QP on project/layer annotation GET
3 participants
@aaronxsu @notthatbreezy @alkamin