Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dependencies and add check to tests #4870

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Remove unused dependencies and add check to tests #4870

merged 3 commits into from
Apr 16, 2019

Conversation

notthatbreezy
Copy link

@notthatbreezy notthatbreezy commented Apr 15, 2019 •
edited
Loading

Overview

Removes unused dependencies and adds a check to tests to help ensure that dependencies are not included in our build that are not absolutely necessary.

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Testing Instructions

  • Assemble all jars, start server, and verify basic functionality

Closes #4737

@notthatbreezy notthatbreezy requested a review from Lknechtli April 15, 2019 14:06
@Lknechtli
Copy link
Contributor

Tried to run migrations and ran into this error:

image

Lknechtli
Lknechtli approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@Lknechtli Lknechtli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work for common functions in projects, layers, analyses, templates, tile server (mosaics, analyses), and migrations

@notthatbreezy notthatbreezy merged commit f184c5f into develop Apr 16, 2019
@notthatbreezy notthatbreezy deleted the feature/cmb/fixup-dependencies branch April 16, 2019 18:39
@jisantuc jisantuc mentioned this pull request Apr 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lknechtli Lknechtli Lknechtli approved these changes

Assignees

@Lknechtli Lknechtli

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Unused Dependencies
2 participants
@notthatbreezy @Lknechtli