Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Analysis Exports, Add Layer Support #4867

Merged
merged 5 commits into from
Apr 12, 2019
Merged

Fix Analysis Exports, Add Layer Support #4867

merged 5 commits into from
Apr 12, 2019

Conversation

notthatbreezy
Copy link

@notthatbreezy notthatbreezy commented Apr 11, 2019 •
edited
Loading

Overview

Creating export definitions still relied on the scenes to projects relationship and didn't fully support layer sources in analyses. This PR adds that support and adds tests that will help us catch future problems hopefully when the underlying database changes.

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible
  • Any new SQL strings have tests

Testing Instructions

  • In an existing project, create an export - note the the export ID in the server logs
  • After rebuilding batch and backsplash-export run ./scripts/console batch "rf export <export-id>"
  • Create an export for a new analysis and select a layer or something, run an export job

Closes #4851

Chris Brown added 4 commits April 9, 2019 19:30
Replace map + flatten with flatMap
387f98f
Add support for project layers to generating export definitions
4d38904 
Before this commit the SQL to generate export definitions relied on
the removed "scenes_to_projects" table and didn't fully support
exporting analyses that had layer sources rather than project sources
Add test to verify that it is possible to create export definitions
69dda79 
Adds test to verify that it is possible to create export definitions
for the following conditions:
 - An analysis with a project + layer raster
 - A project layer export
 - A project export
Various formatting fixes
06717c6
@notthatbreezy notthatbreezy requested a review from jisantuc April 11, 2019 12:28
@notthatbreezy notthatbreezy requested review from aaronxsu and removed request for jisantuc April 11, 2019 12:29
@notthatbreezy notthatbreezy assigned aaronxsu and unassigned jisantuc Apr 11, 2019
aaronxsu
aaronxsu approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@aaronxsu aaronxsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described in the testing instructions. Good to go.

@notthatbreezy notthatbreezy merged commit 6aaa699 into develop Apr 12, 2019
@notthatbreezy notthatbreezy deleted the feature/cmb/fix-analysis-exports branch April 12, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronxsu aaronxsu aaronxsu approved these changes

Assignees

@aaronxsu aaronxsu

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analysis Exports Fail on Develop
3 participants
@notthatbreezy @aaronxsu @jisantuc