Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use geom filter in scene service #4580

Merged
merged 3 commits into from
Feb 5, 2019

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Feb 4, 2019

Overview

This PR includes a geometry filter in trying to read scenes for putting scenes outside of projects on the map with backsplash.

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Testing Instructions

  • open the preview modal for a scene while watching your network tab
  • you shouldn't see any 500s

Closes #4525

@notthatbreezy notthatbreezy self-requested a review February 5, 2019 14:43
Copy link

@notthatbreezy notthatbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, works well and fixes the problem

@@ -137,6 +138,9 @@ class ProjectStoreImplicits(xa: Transactor[IO]) extends ToProjectStoreOps {
val imageBandOverride = bandOverride map { ovr =>
List(ovr.red, ovr.green, ovr.blue)
} getOrElse { List(0, 1, 2) }
// we could also look this up by the datasource at some point -- which would
// probably help with
// https://github.com/raster-foundry/raster-foundry/issues/4468

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated that issue with a link here

@jisantuc jisantuc merged commit ab57ae0 into develop Feb 5, 2019
@aaronxsu aaronxsu deleted the feature/js/use-geom-filter-for-scenes branch February 6, 2019 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants