Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter fields to tool runs #4546

Merged
merged 6 commits into from
Jan 28, 2019
Merged

Add filter fields to tool runs #4546

merged 6 commits into from
Jan 28, 2019

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Jan 25, 2019 •
edited
Loading

Overview

This PR adds tempate, project, and project layer IDs to tool runs to make some filtering possible that isn't currently.

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible
  • Symlinks from new migrations present or corrected for any new migrations
  • Any new SQL strings have tests (and some old ones!)

Notes

Still working on template ID tests because templates don't even have an arbitrary instance omg but backend reviewable as is

Testing Instructions

  • run migrations
  • assemble the api server
  • bring up ur servers
  • create a new analysis from a template in the frontend
  • confirm that the new analysis has the template id filled in in the db

Closes #4530

@jisantuc jisantuc changed the title Feature/js/add fields to tool runs Add filter fields to tool runs Jan 25, 2019
@jisantuc jisantuc requested a review from Lknechtli January 25, 2019 20:47
Lknechtli
Lknechtli approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@Lknechtli Lknechtli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Is there a separate issue to add filtering on these fields through query params on the api endpoints? I can't find it.
We should probably add it this this PR or create a separate issue for it.

app-backend/datamodel/src/test/scala/com/azavea/rf/datamodel/implicits/Generators.scala
owner <- Gen.const(None)
stars <- Gen.const(9999.9f) // good tools only :sunglasses:
definition <- Gen.const(().asJson)
// not super into dealing with tags or categories in testing-land right now
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we have yet to actually do anything with them so this is completely reasonable.

@jisantuc
Copy link
Contributor Author

For posterity: #4531 adds filtering

@jisantuc jisantuc merged commit 037b441 into develop Jan 28, 2019
@jisantuc jisantuc deleted the feature/js/add-fields-to-tool-runs branch January 28, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lknechtli Lknechtli Lknechtli approved these changes

Assignees

@Lknechtli Lknechtli

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jisantuc @Lknechtli