Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize S3 client usage #4441

Merged
merged 10 commits into from
Jan 15, 2019
Merged

Standardize S3 client usage #4441

merged 10 commits into from
Jan 15, 2019

Conversation

aaronxsu
Copy link
Member

@aaronxsu aaronxsu commented Jan 9, 2019 •
edited by jisantuc
Loading

Overview

This PR is based on #2565 -- opening this one up to make jenkins less angry.

This PR standardizes S3 client usage so that the interface now resides in common

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible
  • Styleguide updated, if necessary
  • Swagger specification updated
  • Symlinks from new migrations present or corrected for any new migrations
  • Any content changes are properly templated using BUILDCONFIG.APP_NAME
  • Any new SQL strings have tests

Testing Instructions

  • Go through the process of uploading a GeoTIFF
  • Go through the process of supplying a GeoTIFF via S3 URI
  • Ensure that both processes complete successfully
  • Change organization logo and make sure it still works
  • Test other features like exports etc to make sure S3 interactions work as expected

Closes #1822

@notthatbreezy notthatbreezy mentioned this pull request Jan 9, 2019
Closed
1 task
@aaronxsu aaronxsu changed the title [WIP] Standardize S3 client usage Standardize S3 client usage Jan 10, 2019
jisantuc
jisantuc approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@jisantuc jisantuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised 👌

@jisantuc jisantuc removed the request for review from notthatbreezy January 15, 2019 14:38
@aaronxsu aaronxsu merged commit 7a85ed7 into develop Jan 15, 2019
@aaronxsu aaronxsu deleted the feature/unify-s3 branch January 15, 2019 17:13
jisantuc pushed a commit that referenced this pull request Jan 15, 2019
@jisantuc
Standardize S3 client usage (#4441)
9b6b9da 
* Standardize AmazonS3ClientBuilder usage

Use `AmazonS3ClientBuilder.defaultClient()`, which builds a client using
the `S3CredentialsProviderChain` and `DefaultAwsRegionProviderChain`.

* Fix IOUtils.toString deprecation warning

Need to supply `Charset` as second argument.

* Unify all S3s to common subproject

* Remove S3 interface from batch utility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jisantuc jisantuc jisantuc approved these changes

Assignees

@jisantuc jisantuc

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronxsu @jisantuc @notthatbreezy @hectcastro