Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect user email #4360

Merged
merged 3 commits into from
Dec 6, 2018
Merged

Protect user email #4360

merged 3 commits into from
Dec 6, 2018

Conversation

aaronxsu
Copy link
Member

@aaronxsu aaronxsu commented Dec 5, 2018

Overview

This PR updates the unsafeGetUserById method so that if users are not requesting their own info, the returned other users' email info are protected.

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Demo

screen shot 2018-12-05 at 6 04 13 pm

Testing Instructions

  • In order to test that the issue is resolved by this PR, log into an account with name field set as the same as email field, and no first and last name in personalInfo (so that it will fall to the name case, where the name is the same as email in DB, which happens to some user records)
  • Create a new template
  • In DB, change its visibility to PUBLIC or modify its acrs to share it to another account (directly, through group membership, etc)
  • Log into this other account and go the list of templates
  • Make sure only email user name (without @domain) or Anonymous is displayed as owner for that shared template

Closes https://github.com/azavea/raster-foundry-platform/issues/568

@aaronxsu aaronxsu force-pushed the feature/asu/obfuscate-user-emails branch from f00ebad to e83a955 Compare December 6, 2018 15:20
@aaronxsu aaronxsu merged commit e05f57f into develop Dec 6, 2018
@aaronxsu aaronxsu deleted the feature/asu/obfuscate-user-emails branch December 6, 2018 16:08
@notthatbreezy notthatbreezy removed their assignment May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants