Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to decline invitations or leave groups #4358

Merged
merged 2 commits into from
Dec 6, 2018
Merged

Allow users to decline invitations or leave groups #4358

merged 2 commits into from
Dec 6, 2018

Conversation

aaronxsu
Copy link
Member

@aaronxsu aaronxsu commented Dec 5, 2018 •
edited
Loading

Overview

This PR updates authorization checks on team and organization member endpoints, so that, in addition to admins, if the acting user matches the user to be removed, the acting user is allowed to decline a team or organization invitation, or to leave a team or an organization.

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Notes

The original issue changed a tiny bit per the comment in there.

Testing Instructions

  • Log in as a platform admin
  • Create an organization
  • Add your other account as organization member
  • Log in to the other account
  • Go to the list of your organizations
  • Check if both accept and decline work. If you accepted, you should be able to leave the organization as well.
  • Test the team scenario following similar instructions as above and check if it works.

Closes #4327
Closes #4213

@aaronxsu aaronxsu requested review from alkamin and Lknechtli and removed request for alkamin December 5, 2018 19:16
@aaronxsu aaronxsu assigned Lknechtli and unassigned alkamin Dec 6, 2018
@aaronxsu
Update authorization check on removing members from team or from orga…
212cd14 
…nization

Allow the acting user to decline team or organization invitations.
Allow the acting user to leave team or organization.
@aaronxsu
Update changelog
8b361ca
@aaronxsu aaronxsu force-pushed the feature/asu/team-invite-bug-fix branch from 3820f0c to 8b361ca Compare December 6, 2018 16:57
@aaronxsu aaronxsu merged commit f3b1fe3 into develop Dec 6, 2018
@aaronxsu aaronxsu deleted the feature/asu/team-invite-bug-fix branch December 6, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lknechtli Lknechtli Lknechtli approved these changes

Assignees

@Lknechtli Lknechtli

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronxsu @Lknechtli @alkamin