Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements a handful of styling fixes within projects #4355

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Implements a handful of styling fixes within projects #4355

merged 2 commits into from
Dec 5, 2018
+16 −1

Conversation

designmatty
Copy link
Contributor

@designmatty designmatty commented Dec 5, 2018 •
edited by Lknechtli
Loading

Overview

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Demo

1: List group issue, before:
screen shot 2018-12-05 at 11 12 24 am

1: List group after fix, all themes
screen shot 2018-12-05 at 11 09 25 am
screen shot 2018-12-05 at 11 11 09 am
screen shot 2018-12-05 at 11 12 03 am

2: Search select invisble text, before:
screen shot 2018-12-05 at 11 18 56 am

2: Search select text after fix, all themes:
screen shot 2018-12-05 at 11 04 16 am
screen shot 2018-12-05 at 11 09 22 am
screen shot 2018-12-05 at 11 11 22 am

Testing Instructions

  • Open project
  • Check scene list as they load to check for thumbnail load issue
  • Check scene list item that contains a long image source name to make sure buttons don't go on two lines
  • Type into the imagery source searchbox. Make sure the typed text is visible

fixes searchselect style bug
39d85bf 
fixes thumbnail loading size issue on list-groups
fixes flex issue in list-groups for long source names
@designmatty designmatty requested a review from Lknechtli December 5, 2018 16:22
@Lknechtli Lknechtli merged commit e5e9197 into develop Dec 5, 2018
Lknechtli
Lknechtli reviewed Dec 5, 2018
View reviewed changes
Copy link
Contributor

@Lknechtli Lknechtli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Lknechtli Lknechtli deleted the feature/mw/bug-fixes branch December 5, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lknechtli Lknechtli Lknechtli left review comments

Assignees

@Lknechtli Lknechtli

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scene browse imagery source filter broken
2 participants
@designmatty @Lknechtli