Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let platform admins set upload owners #4237

Merged
merged 5 commits into from
Oct 22, 2018
Merged

Let platform admins set upload owners #4237

merged 5 commits into from
Oct 22, 2018
+205 −51

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Oct 18, 2018 •
edited
Loading

Overview

This PR makes it so that platform admins can set owners who aren't them on upload objects while preserving that power for superusers.

Checklist

  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible
  • Weird heavy case sequence is tested

Testing Instructions

  • look at the tests

Closes #4226

@jisantuc jisantuc requested a review from aaronxsu October 18, 2018 14:29
jisantuc
jisantuc commented Oct 19, 2018
View reviewed changes
app-backend/db/src/test/scala/com/azavea/rf/database/DatasourceDaoSpec.scala
UploadStatus.Uploaded,
UploadStatus.Queued,
UploadStatus.Processing)
status = Random.shuffle(statuses).head
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the arbitrary instance already randomly chooses a status, we don't need to add extra randomness here, and can just test the deletable condition against the status we got from the first die roll.

aaronxsu
aaronxsu approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@aaronxsu aaronxsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 👍

@jisantuc jisantuc force-pushed the feature/js/let-platform-admins-set-upload-owners branch from 800b663 to a1a70f0 Compare October 22, 2018 15:39
@jisantuc jisantuc merged commit 93a62bf into develop Oct 22, 2018
@jisantuc jisantuc deleted the feature/js/let-platform-admins-set-upload-owners branch October 22, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronxsu aaronxsu aaronxsu approved these changes

Assignees

@aaronxsu aaronxsu

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jisantuc @aaronxsu