nvtx support macos #474
Merged
nvtx support macos #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
improvement
madsbk
force-pushed
the
convert_to_64bit
branch
from
9cbae8d
to
a28d806
Compare
vuule
reviewed
Sep 26, 2024
cpp/include/kvikio/utils.hpp
Outdated
| template <typename T, std::enable_if_t<std::is_integral_v<T>>* = nullptr> | ||
| [[nodiscard]] std::int64_t convert_to_64bit(T value) | ||
| { | ||
| if (value >= std::numeric_limits<std::int64_t>::max()) { |
There was a problem hiding this comment.
This function is probably not performance critical, but we could check if the type can overflow int64 with an if constexpr, so some instantiations don't even have the max() check.
vuule
approved these changes
Sep 26, 2024
wence-
approved these changes
Sep 30, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471