-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster Provisioning: added RKE2 section #4075
Conversation
Fixes #3752 Split the Cluster Provisioning between RKE and RKE2 documentation. To keep a "reading standardization", both sections have the same sub-topics. Once the structure is agreed, RKE2 content needs to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Programmatically Creating RKE Clusters" section
- Needs to have a corresponding link for RKE2 (https://registry.terraform.io/providers/rancher/rancher2/latest/docs/resources/cluster_v2)
- Should be moved to the bottom (so the RKE and RKE2 sections are sequential) OR this should be made into a subsection within each of the RKE and RKE2 sections
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Billy Tat <btat@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits on the original docs :)
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/node-pools/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/cluster-provisioning/rke-clusters/node-pools/_index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add that the vSphere node driver supports Windows? That is a key feature.
Split the Cluster Provisioning between RKE and RKE2 documentation.
To keep a "reading standardization", both sections have the same sub-topics.
Once the structure is agreed, RKE2 content needs to be updated.
For Rancher (product) docs only
When contributing to docs, please update the versioned docs. For example, the docs in the v2.6 folder of the
rancher
folder.Doc versions older than the latest minor version should only be updated to fix inaccuracies or make minor updates as necessary. The majority of new content should be added to the folder for the latest minor version.