This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
Migrate to Prometheus 2.1.0 and Grafana 5.0.0 #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sliard Looks good, it's probably worth updating the default version to match your new entry. Can be done in the main config file, you okay to push that up as an update? |
|
No problem. I just didn't want to force this update and let you choose. :) |
|
Won't force it on anyone. That version number needs adjusting in the base folder config.yaml file to update the default version. If we want to hold off on that for a little while though, that's fine. |
|
@cloudnautique Looks good to merge to me, haven't had chance to test myself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Prometheus and Grafana version.
Will work only when infinityworks upgrade infinityworks/prom-conf with this pull request :
infinityworks/prom-conf#6