Add CoreDNS template for community-catalog #746

Jason-ZW · 2018-02-28T06:36:01Z

Hi,all:

This PR added coredns for community-catalog.

Details as below:

CoreDNS image: coredns/coredns:1.0.1

Use confd(backend rancher) sidekick generate CoreDNS's Corefile.

Currently CoreDNS for this catalog only support etcd backend.If you want to use Kubernetes backend,please use coredns helm chart.

support 7+ plugins, user can customization plugin through catalog template.
support A/AAAA,PTR records.
support forward
support upstream

If you want to learn more, please see README documentation.

Hope this PR can be merged.

Best Regards!

niusmallnan · 2018-02-28T06:42:01Z

templates/coredns/config.yml

+version: 0.8.0
+category: External DNS
+labels:
+  io.rancher.orchestration.supported: 'cattle,mesos,swarm,kubernetes'


only cattle here？

@niusmallnan only cattle, because for kubernetes it already had coredns helm chart, which better support for kubernetes.

niusmallnan · 2018-02-28T06:45:27Z

templates/coredns/0/docker-compose.yml

+    - 53:53/tcp
+    - 53:53/udp
+  volumes_from:
+  - data


Please use a unified indentation

niusmallnan · 2018-02-28T13:37:11Z

templates/coredns/0/README.md

+- Log plugin support: weather to enable log plugin.
+- Proxy plugin support: weather to enable proxy plugin.
+- Cache plugin support: weather to enable cache plugin.
+- Loadbalance plugin support: weatherto enable loadbalance plugin.


weatherto is a typo.
whether?

Already fixed.

niusmallnan · 2018-02-28T13:41:35Z

templates/coredns/0/rancher-compose.yml

+      label: "Forward addresses"
+      description: "The address which to be forwarded DNS query."
+      type: "string"
+      default: "8.8.8.8:53,4.4.4.4:53"


I think you want to use 8.8.4.4?

Sorry my mistake.Already fixed.

niusmallnan · 2018-02-28T13:48:39Z

templates/coredns/0/rancher-compose.yml

@@ -0,0 +1,84 @@
+.catalog:
+  name: "CoreDNS"
+  version: "0.8.0"


It would be nice if you use the coredns version.
For users, they may not know the meaning of the 0.8 version.

Changed to 1.0.1 compatible with coredns version.

niusmallnan · 2018-02-28T13:50:16Z

templates/coredns/0/docker-compose.yml

+  volumes_from:
+    - data
+data:
+  image: zhenyangzhao/coredns-file:v0.8.0


I am not sure if you need a different image here.
Can you reuse the coredns/coredns image? If not, it's ok.
It's up to you.

Sorry this can not be reused.

rawmind0 · 2018-03-01T08:52:15Z

templates/coredns/0/rancher-compose.yml

@@ -0,0 +1,84 @@
+.catalog:


Could you please use compose version 2 notation??

-.catalog: +version: '2' +catalog:

rawmind0 · 2018-03-01T08:54:15Z

templates/coredns/0/rancher-compose.yml

+    strategy: recreate
+    request_line: GET "/health" "HTTP/1.0"
+    reinitializing_timeout: 60000
+


Could you please use compose version 2 notation??

-coredns: - scale: 1 - health_check: - response_timeout: 4000 - healthy_threshold: 2 - port: 8080 - unhealthy_threshold: 3 - initializing_timeout: 60000 - interval: 2000 - strategy: recreate - request_line: GET "/health" "HTTP/1.0" - reinitializing_timeout: 60000 +services: + coredns: + scale: 1 + health_check: + response_timeout: 4000 + healthy_threshold: 2 + port: 8080 + unhealthy_threshold: 3 + initializing_timeout: 60000 + interval: 2000 + strategy: recreate + request_line: GET "/health" "HTTP/1.0" + reinitializing_timeout: 60000

rawmind0 · 2018-03-01T08:59:04Z

templates/coredns/0/docker-compose.yml

+    PLUGIN_FORWARDS: ${FORWARDS}
+  volumes:
+    - /etc/coredns
+


Could you please use compose version 2 notation??

-coredns: - image: coredns/coredns:1.0.1 - labels: - io.rancher.sidekicks: data - io.rancher.container.hostname_override: container_name - command: [ "-conf", "/etc/coredns/Corefile" ] - ports: - - 53:53/tcp - - 53:53/udp - volumes_from: - - data -data: - image: zhenyangzhao/coredns-file:v0.8.0 - labels: - io.rancher.container.start_once: 'true' - environment: - PLUGIN_ZONES: ${ZONES} - PLUGIN_ROOT_PATH: ${ROOT_PATH} - PLUGIN_ETCD_ENDPOINTS: ${ETCD_ENDPOINTS} - PLUGIN_UPSTREAM: ${UPSTREAM} - PLUGIN_PROM: ${PLUGIN_PROM} - PLUGIN_ERRORS: ${PLUGIN_ERRORS} - PLUGIN_LOG: ${PLUGIN_LOG} - PLUGIN_HEALTH: true - PLUGIN_PROXY: ${PLUGIN_PROXY} - PLUGIN_CACHE: ${PLUGIN_CACHE} - PLUGIN_LOADBALANCE: ${PLUGIN_LOADBALANCE} - PLUGIN_FORWARDS: ${FORWARDS} - volumes: - - /etc/coredns +version: '2' +services: + coredns: + image: coredns/coredns:1.0.1 + labels: + io.rancher.sidekicks: data + io.rancher.container.hostname_override: container_name + command: [ "-conf", "/etc/coredns/Corefile" ] + ports: + - 53:53/tcp + - 53:53/udp + volumes_from: + - data + data: + image: zhenyangzhao/coredns-file:v0.8.0 + labels: + io.rancher.container.start_once: 'true' + environment: + PLUGIN_ZONES: ${ZONES} + PLUGIN_ROOT_PATH: ${ROOT_PATH} + PLUGIN_ETCD_ENDPOINTS: ${ETCD_ENDPOINTS} + PLUGIN_UPSTREAM: ${UPSTREAM} + PLUGIN_PROM: ${PLUGIN_PROM} + PLUGIN_ERRORS: ${PLUGIN_ERRORS} + PLUGIN_LOG: ${PLUGIN_LOG} + PLUGIN_HEALTH: true + PLUGIN_PROXY: ${PLUGIN_PROXY} + PLUGIN_CACHE: ${PLUGIN_CACHE} + PLUGIN_LOADBALANCE: ${PLUGIN_LOADBALANCE} + PLUGIN_FORWARDS: ${FORWARDS} + volumes: + - coredns_data:/etc/coredns +volumes: + coredns_data: + driver: local + per_container: true

rawmind0 · 2018-03-01T09:06:01Z

templates/coredns/0/docker-compose.yml

+  command: [ "-conf", "/etc/coredns/Corefile" ]
+  ports:
+    - 53:53/tcp
+    - 53:53/udp


What do you think if you add a question PUBLISH_PORT, with default value of 53, to be able to publish the service in configurable port??

- - 53:53/tcp - - 53:53/udp + - ${PUBLISH_PORT}:${PUBLISH_PORT}/tcp + - ${PUBLISH_PORT}:${PUBLISH_PORT}/udp

Also a modification at line 1 of https://github.com/Jason-ZW/Dockerfile/blob/master/coredns/Corefile.tmpl would be needed.

-.:53 { +.:{{ getenv "PUBLISH_PORT" }} {

rawmind0 · 2018-03-01T09:14:54Z

templates/coredns/0/docker-compose.yml

+    PLUGIN_PROXY: ${PLUGIN_PROXY}
+    PLUGIN_CACHE: ${PLUGIN_CACHE}
+    PLUGIN_LOADBALANCE: ${PLUGIN_LOADBALANCE}
+    PLUGIN_FORWARDS: ${FORWARDS}


Using variable PUBLISH_PORT

+ PUBLISH_PORT: ${PUBLISH_PORT}

rawmind0 · 2018-03-01T09:22:29Z

templates/coredns/0/rancher-compose.yml

+      description: "Etcd service endpoints."
+      type: "string"
+      default: "http://localhost:2379"
+      required: true


Inside container will be already running an etcd service?? If not, default value wouldn't work...
May be it'd be better to leave blank default value, to force users to set the correct etcd endpoints. btw, multiple values are allowed??

rawmind0 · 2018-03-01T09:23:34Z

Hi @Jason-ZW , thanks for the PR and contribute. :)

Please, take a look to the changes requested.

Jason-ZW · 2018-03-01T13:12:02Z

@rawmind0 Thanks for reply me. I have modified the code according to all the Suggestions. Could you please to review it again？
Thanks a lot.

rawmind0 · 2018-03-01T14:36:49Z

@Jason-ZW , thanks for the changes.

The package is right now, but there is a little error at Corefile.tmpl. I've opened a PR to fix it, please take a look. Jason-ZW/Dockerfile#1

Another question, sidekick has to keep running?? It's getting config from env vars, in which circumstances config could automatically change?? May be better to run confd with --onetime and sidekick as run once and network_mode: none?? Config would be updated running again sidekick.

Jason-ZW · 2018-03-01T15:28:52Z

@rawmind0 Already removed run_once label from sidekick container. Already added io.rancher.container.pull_image: always on sidekick container.

rawmind0 · 2018-03-01T15:32:45Z

Then, sidekick needs to keep running?? It's getting config from env vars, in which circumstances config could automatically get updated??

Jason-ZW · 2018-03-01T16:49:54Z

@rawmind0 Sorry for reply later. I just reviewed coredns's docs, there is no way to refresh server's config but restart or maybe i'm not found.So i rollback the code to make sidekick container start_once=true. Dockerfile already added -onetime parameter.Thanks a lot.

rawmind0 · 2018-03-01T17:33:01Z

Thanks, i think better like that. Other point, why are you using rancher backend in confd execution?? You are just getting data from env variables, you don't need metadata backend connection.

You could use env backend confd -onetime -backend env and disable network at sidekick network_mode: none. Tested and working fine.

Please, take a look to the changes requested.

rawmind0 · 2018-03-01T17:32:15Z

templates/coredns/0/docker-compose.yml

+      PLUGIN_FORWARDS: ${FORWARDS}
+      PUBLISH_PORT: ${PUBLISH_PORT}
+    volumes:
+      - coredns_data:/etc/coredns


Using env backend and disabling network at sidekick.

+ network_mode: none + entrypoint: + - confd + - -backend + - env + - -onetime

@rawmind0 Fixed as you said. :)

rawmind0 · 2018-03-01T18:12:16Z

@Jason-ZW , thanks for the changes...

LGTM...

Jason-ZW · 2018-03-02T00:58:54Z

@rawmind0 Thank you for your patience.：）

niusmallnan reviewed Feb 28, 2018

View reviewed changes

templates/coredns/0/docker-compose.yml Outdated

- 53:53/tcp

- 53:53/udp

volumes_from:

- data

Copy link

niusmallnan Feb 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a unified indentation

Jason-ZW changed the title ~~Add CoreDNS template for community-catalog~~ WIP: Add CoreDNS template for community-catalog Feb 28, 2018

Jason-ZW changed the title ~~WIP: Add CoreDNS template for community-catalog~~ Add CoreDNS template for community-catalog Feb 28, 2018

niusmallnan reviewed Feb 28, 2018

View reviewed changes

rawmind0 suggested changes Mar 1, 2018

View reviewed changes

rawmind0 approved these changes Mar 1, 2018

View reviewed changes

rawmind0 and others added 2 commits March 1, 2018 23:14

Updated traefik to v1.5.2

a2eabe0

update to version 2018-02-09_1

bf6c4bd

rawmind0 suggested changes Mar 1, 2018

View reviewed changes

rancher-sy-bot added 2 commits March 2, 2018 01:39

Catalog for CoreDNS cattle orchestration.

fde452c

Merge branch 'master' into master

7f6f06d

rawmind0 approved these changes Mar 1, 2018

View reviewed changes

rawmind0 merged commit 8ef1b8c into rancher:master Mar 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CoreDNS template for community-catalog #746

Add CoreDNS template for community-catalog #746

Jason-ZW commented Feb 28, 2018

niusmallnan Feb 28, 2018

Jason-ZW Feb 28, 2018

niusmallnan Feb 28, 2018

niusmallnan Feb 28, 2018 •

edited

Loading

Jason-ZW Feb 28, 2018

niusmallnan Feb 28, 2018

Jason-ZW Feb 28, 2018

niusmallnan Feb 28, 2018

Jason-ZW Feb 28, 2018

niusmallnan Feb 28, 2018

Jason-ZW Feb 28, 2018 •

edited

Loading

rawmind0 Mar 1, 2018

rawmind0 Mar 1, 2018

rawmind0 Mar 1, 2018

rawmind0 Mar 1, 2018

rawmind0 Mar 1, 2018

rawmind0 Mar 1, 2018

rawmind0 commented Mar 1, 2018

Jason-ZW commented Mar 1, 2018

rawmind0 commented Mar 1, 2018 •

edited

Loading

Jason-ZW commented Mar 1, 2018

rawmind0 commented Mar 1, 2018

Jason-ZW commented Mar 1, 2018 •

edited

Loading

rawmind0 commented Mar 1, 2018 •

edited

Loading

rawmind0 Mar 1, 2018

Jason-ZW Mar 1, 2018

rawmind0 commented Mar 1, 2018

Jason-ZW commented Mar 2, 2018

Add CoreDNS template for community-catalog #746

Add CoreDNS template for community-catalog #746

Conversation

Jason-ZW commented Feb 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niusmallnan Feb 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jason-ZW Feb 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rawmind0 commented Mar 1, 2018

Jason-ZW commented Mar 1, 2018

rawmind0 commented Mar 1, 2018 • edited Loading

Jason-ZW commented Mar 1, 2018

rawmind0 commented Mar 1, 2018

Jason-ZW commented Mar 1, 2018 • edited Loading

rawmind0 commented Mar 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rawmind0 commented Mar 1, 2018

Jason-ZW commented Mar 2, 2018

niusmallnan Feb 28, 2018 •

edited

Loading

Jason-ZW Feb 28, 2018 •

edited

Loading

rawmind0 commented Mar 1, 2018 •

edited

Loading

Jason-ZW commented Mar 1, 2018 •

edited

Loading

rawmind0 commented Mar 1, 2018 •

edited

Loading