add filebeat for rancher catalog for fast deployment #733
Conversation
templates/filebeat/config.yml
Outdated
| version: 6.1.1 | ||
| category: Shipper | ||
| #maintainer: eason.lau02@hotmail.com | ||
| #license: MIT |
There was a problem hiding this comment.
Maintainer field was failing on build, due to bad format, instead of comment out could you please fix it to fit format??...Needs to be specified as maintainer: "<NAME> <SURNAME> <<EMAIL>>"
Any reason to comment out License field??
-#maintainer: eason.lau02@hotmail.com
+maintainer: "Eason Lau <eason.lau02@hotmail.com>"
| container_name: filebeat-alpine-5.3.1 | ||
| restart: always | ||
| labels: | ||
| io.rancher.container.pull_image: always |
There was a problem hiding this comment.
You don't need to pull image always.
- labels:
- io.rancher.container.pull_image: always
There was a problem hiding this comment.
Oh yes. which is my rancher docker-compose version. Remove at next commit.
| container_name: filebeat-alpine-5.6.3 | ||
| restart: always | ||
| labels: | ||
| io.rancher.container.pull_image: always |
There was a problem hiding this comment.
You don't need to pull image always.
- labels:
- io.rancher.container.pull_image: always
| container_name: filebeat-alpine-6.1.1 | ||
| restart: always | ||
| labels: | ||
| io.rancher.container.pull_image: always |
There was a problem hiding this comment.
You don't need to pull image always.
- labels:
- io.rancher.container.pull_image: always
| version: "6.1.1" | ||
| description: "Catalog's rancher-compose" | ||
| minimun_rancher_version: v1.0.1 | ||
| maximun_rancher_version: v1.6.12 |
There was a problem hiding this comment.
With this config, package wouldn't be showed at rancher latest version...Not working at last rancher version release v1.6.14??
If works, better...
- maximun_rancher_version: v1.6.12
| version: "5.6.3" | ||
| description: "Catalog's rancher-compose" | ||
| minimun_rancher_version: v1.0.1 | ||
| maximun_rancher_version: v1.6.12 |
There was a problem hiding this comment.
With this config, package wouldn't be showed at rancher latest version...Not working at last rancher version release v1.6.14??
If works, better...
- maximun_rancher_version: v1.6.12
| version: "5.3.1" | ||
| description: "Catalog's rancher-compose" | ||
| minimun_rancher_version: v1.0.1 | ||
| maximun_rancher_version: v1.6.12 |
There was a problem hiding this comment.
With this config, package wouldn't be showed at rancher latest version...Not working at last rancher version release v1.6.14??
If works, better...
- maximun_rancher_version: v1.6.12
There was a problem hiding this comment.
Actually it supports. Updated later.
| - QA | ||
| - PP | ||
| - INT | ||
| - PROD |
There was a problem hiding this comment.
It's nice to have predefined values, but what happens if my environments notation is different?? Mey would be better to use an string type to allow free input. What do you think??
| - QA | ||
| - PP | ||
| - INT | ||
| - PROD |
There was a problem hiding this comment.
It's nice to have predefined values, but what happens if my environments notation is different?? Mey would be better to use an string type to allow free input. What do you think??
| - QA | ||
| - PP | ||
| - INT | ||
| - PROD |
There was a problem hiding this comment.
It's nice to have predefined values, but what happens if my environments notation is different?? Mey would be better to use an string type to allow free input. What do you think??
…info/MAX RANCHER VERSION
|
Updated and passed checking. @rawmind0 |
|
Hi @easonlau02 , thanks for PR and the changes. You are assuming that the package would be run at host level, forcing network_mode and bind volumes to get config and logs files. What do you think to add distinct volumes driver as bind, nfs,... to make the package more versatile?? May be better if ${APPLOG_PATH} and ${NGINXLOG_PATH} volumes would be mounted in read-only mode?? Also network-mode could be managed too if logstash would be running inside rancher. What do you think add hosts or managed option?? |
|
hi @rawmind0, thanks for your fast review. For Now let |
|
I get your point @easonlau02, thanks for the changes. LGTM... |
Merge pull request rancher#733 from easonlau02/filebeat-6.1.1
Hi guys,
Here to add filebeat 6.1.1 for rancher catalog for fast deployment.
Hope we can use at the rancher community catalog.
Please kindly help review. Thanks.
Regards/Eason