Misc fixes #1458
Misc fixes #1458
Conversation
- progress bar was a descendant of the dataCell typography which was a <p> - so we just change it to be a <span>
Codecov ReportBase: 97.65% // Head: 97.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1458 +/- ##
========================================
Coverage 97.65% 97.65%
========================================
Files 158 158
Lines 7214 7215 +1
Branches 2275 2276 +1
========================================
+ Hits 7045 7046 +1
Misses 152 152
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
- also, change the loglevel import to the more standard form as this is now preferred according to their docs
- we were wrongly awaiting fetchNextPage, so call it normally and await for it to start fetching & finish fetching
- also change adminDownloadStatus table to not use jest timers I think the reason for the flaky tests is that user.type is quite slow (as it types every character & event handlers are run on them) and these tests have multiple calls to user.type If they continue to be flaky these tests should be split up so that there's not multiple user.type calls in the same test
|
Between the last 2 commits I did 7 runs of the unit tests and they passed every time, which seems more stable than previously |
There was a problem hiding this comment.
I kind of skipped over the enzyme tests changes and the snapshot changes, as I have already rewritten all of them in RTL in #1447.
...y-download/src/downloadStatus/__snapshots__/adminDownloadStatusTable.component.test.tsx.snap
Show resolved
Hide resolved
Description
A branch primarily motiviated to try and fix the download test failures, but is now doing a few misc fixes/improvements:
DataCellpreviously rendered as apwhich has strict limits on what it's children can be - it's now aspanwhich encapsulates being a single line better than adivTesting instructions
Add a set up instructions describing how the reviewer should test the code