Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security vulnerabilities reverted by MUIv5 branch #1314

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

louise-davies
Copy link
Member

@louise-davies louise-davies commented Jul 11, 2022

Description

Due to the MUIv5 branch, some security fixes to yarn.lock were lost, and since dependabot doens't work with yarn v2 I thought I'd just manually fix these. I also ran yarn dedupe to tidy up the lock file

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1314 (ca21418) into develop (eebfd67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1314   +/-   ##
========================================
  Coverage    97.25%   97.25%           
========================================
  Files          133      133           
  Lines         6728     6728           
  Branches      2073     2073           
========================================
  Hits          6543     6543           
  Misses         171      171           
  Partials        14       14           
Flag Coverage Δ
common 97.79% <ø> (ø)
dataview 97.96% <ø> (ø)
download 94.89% <ø> (ø)
search 96.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eebfd67...ca21418. Read the comment docs.

@louise-davies louise-davies requested a review from kennethnym July 11, 2022 15:10
Copy link
Member

@kennethnym kennethnym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@louise-davies louise-davies merged commit 21ab461 into develop Jul 11, 2022
@louise-davies louise-davies deleted the update-dependencies branch July 11, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants