Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download Type status requests are cached and could be stale #1519

Closed
louise-davies opened this issue Mar 17, 2023 · 0 comments · Fixed by #1576
Closed

Download Type status requests are cached and could be stale #1519

louise-davies opened this issue Mar 17, 2023 · 0 comments · Fixed by #1576
Assignees
@kaperoo
Labels
datagateway-download Issues relating to the download plugin user feedback Issues that were raised by users

Comments

@louise-davies
Copy link
Member

Description:
Currently, we query for download type statuses when the download confirmation dialogue is opened. But because we cache these requests, there can be potential issues. e.g. User submits big download, sysadmins notice this and temporarily disables the download type to stop the IDS from being overloaded, User (who still has DG open) submits new download request. It might be sensible to set a cache time to 0 for the download type status requests. However, we should check with Chris (I have previously discussed this with Sabah as a user submitted a download to a disabled download type and we're unsure how it happened - this issue is something I suspect could have happened).
@louise-davies louise-davies added question Further information is requested datagateway-download Issues relating to the download plugin user feedback Issues that were raised by users labels Mar 17, 2023
@louise-davies louise-davies changed the title Download Type statuses are cached and could be stale Download Type status requests are cached and could be stale Mar 17, 2023
@louise-davies louise-davies removed the question Further information is requested label Aug 11, 2023
kaperoo added a commit that referenced this issue Aug 16, 2023
@kaperoo
changed cacheTime for status type requests #1519
ca2a7bf
kaperoo added a commit that referenced this issue Aug 17, 2023
@kaperoo
set staleTime to 0 #1519
fa4fcbc
kaperoo added a commit that referenced this issue Aug 20, 2023
@kaperoo
Tests for download type status caching #1519
8dc8dd0
@kaperoo kaperoo mentioned this issue Aug 21, 2023
Merged
3 tasks
@kaperoo kaperoo linked a pull request Aug 21, 2023 that will close this issue
Feature/download type status cache #1519 #1576
Merged
3 tasks
kaperoo added a commit that referenced this issue Aug 24, 2023
@kaperoo
Merge pull request #1576 from ral-facilities/feature/download-type-st…
6e0ba51 
…atus-cache-#1519

Feature/download type status cache #1519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaperoo kaperoo

Labels
datagateway-download Issues relating to the download plugin user feedback Issues that were raised by users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/download type status cache #1519 ral-facilities/datagateway
2 participants
@louise-davies @kaperoo