Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6 #683

Closed
m-andreas opened this issue Mar 7, 2019 · 17 comments
Closed

Rails 6 #683

m-andreas opened this issue Mar 7, 2019 · 17 comments

Comments

@m-andreas
Copy link

As rails 6 Beta is out, are there any plans for rails 6 already?

@wpolicarpo
Copy link
Member

Not yet. PRs are welcome now that 5.2.0 was released.

@wpolicarpo
Copy link
Member

For those willing to help, #690 is waiting for some contributors.

@juice
Copy link

juice commented Aug 20, 2019

Rails 6.0 is released.

@net1957
Copy link

net1957 commented Sep 11, 2019

I'm trying to update to rails 6 and hit this problem.

Seems to turn around @columns_hash. Some code did change in AR.
I tried the 6.0 dev branch and get
ArgumentError (wrong number of arguments (given 7, expected 2..5)): error

Have you an idea on the time frame needed to modify this great code ?

Can I help on some aspects ?
Regards

@gr8bit gr8bit mentioned this issue Oct 23, 2019
@spacerobotTR
Copy link

Is a rails 6.0 release being worked on still?

@ttilberg
Copy link

@wpolicarpo You have a branch linked above that was a draft for Rails 6 wip, so you seem to have some experience working on the adapter. Can you provide some public insight about what kind of changes happened to AR that make SQL Server hard to support? I'm not trying to pin you down specifically, it's just that there's been a lot of stalled progress on both TinyTDS and AR Adapter. It has me wondering what challenges have been presented (and ultimately, whether it's anything I can help make progress against). Thanks!

@dglaser
Copy link

dglaser commented Feb 4, 2020

@ttilberg The "Rails 6 wip" branch has not merged any pull requests. I believe my pull request ( #714 ) is the latest. This PR includes:

  • 6 0 dev #710 - changed the parameters for sql_for_insert method to match changes to active-record
  • I changed the rails version to 6.0.0 from 6.0.0.beta3

These small changes cleared up a lot of the failing tests and errors. Unfortunately, there are still failing tests due to one of two issues:

  1. ActiveRecord::StatementInvalid: TinyTds::Error: Cannot insert explicit value for identity column in table 'posts' when IDENTITY_INSERT is set to OFF.
  2. ActiveRecord::ConnectionNotEstablished: No connection pool with 'primary' found.

@ttilberg
Copy link

@dglaser I've found something relevant to the 1st note -- I added a pr to yours.

@johan-smits
Copy link

Meanwhile this support is in progress are there alternatives?

@wpolicarpo
Copy link
Member

Hey guys, unfortunately there are no alternatives, except to help with the migration :(

I released v5.2.1 yesterday and master is green-ish again (thanks to @aidanharan) so we can focus on Rails 6 in #690 as I already mentioned.

@johan-smits
Copy link

@wpolicarpo I ended up downgrading my rails setup because the app was simple.

I don't have enough experience to help with the migration but will track the status of this issue when there are test users needed.

@JesseChavez
Copy link

JesseChavez commented Apr 3, 2020

@johan-smits and @mentions If you guys don't mind JRuby there is already an alternative SQL Server adapter with Rails 6.0 support since last year.

I already have some huge apps in production. Bear in mind it only works in JRuby.

@matthewdunbar
Copy link
Contributor

Thanks for all the work you all have done upgrading to Rails 6. I upgraded using the 6-0-dev branch about a week ago and haven't run into any kind of significant issues.

@tbonz
Copy link

tbonz commented May 15, 2020

It's been awesome to follow the progress made over the past months. Great to see 6.0.0rc1 out there now! Nice work!

@wpolicarpo
Copy link
Member

Hi guys, version 6.0.0.rc1 is out.

Please test and report any issues you may find.

Closing this.

@johan-smits
Copy link

@JesseChavez to me it is looking good! Thanks for the effort of all the contributors!

@net1957
Copy link

net1957 commented May 26, 2020

rc2 is working for me on Rails 6.0.3.1
Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests