-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 6 #683
Comments
Not yet. PRs are welcome now that 5.2.0 was released. |
For those willing to help, #690 is waiting for some contributors. |
Rails 6.0 is released. |
I'm trying to update to rails 6 and hit this problem. Seems to turn around @columns_hash. Some code did change in AR. Have you an idea on the time frame needed to modify this great code ? Can I help on some aspects ? |
Is a rails 6.0 release being worked on still? |
@wpolicarpo You have a branch linked above that was a draft for Rails 6 wip, so you seem to have some experience working on the adapter. Can you provide some public insight about what kind of changes happened to AR that make SQL Server hard to support? I'm not trying to pin you down specifically, it's just that there's been a lot of stalled progress on both TinyTDS and AR Adapter. It has me wondering what challenges have been presented (and ultimately, whether it's anything I can help make progress against). Thanks! |
@ttilberg The "Rails 6 wip" branch has not merged any pull requests. I believe my pull request ( #714 ) is the latest. This PR includes:
These small changes cleared up a lot of the failing tests and errors. Unfortunately, there are still failing tests due to one of two issues:
|
@dglaser I've found something relevant to the 1st note -- I added a pr to yours. |
Meanwhile this support is in progress are there alternatives? |
Hey guys, unfortunately there are no alternatives, except to help with the migration :( I released v5.2.1 yesterday and master is green-ish again (thanks to @aidanharan) so we can focus on Rails 6 in #690 as I already mentioned. |
@wpolicarpo I ended up downgrading my rails setup because the app was simple. I don't have enough experience to help with the migration but will track the status of this issue when there are test users needed. |
@johan-smits and @mentions If you guys don't mind JRuby there is already an alternative SQL Server adapter with Rails 6.0 support since last year. I already have some huge apps in production. Bear in mind it only works in JRuby. |
Thanks for all the work you all have done upgrading to Rails 6. I upgraded using the 6-0-dev branch about a week ago and haven't run into any kind of significant issues. |
It's been awesome to follow the progress made over the past months. Great to see 6.0.0rc1 out there now! Nice work! |
Hi guys, version 6.0.0.rc1 is out. Please test and report any issues you may find. Closing this. |
@JesseChavez to me it is looking good! Thanks for the effort of all the contributors! |
rc2 is working for me on Rails 6.0.3.1 |
As rails 6 Beta is out, are there any plans for rails 6 already?
The text was updated successfully, but these errors were encountered: