Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid infinate loops due to circular association referecnes. #789

Closed
wants to merge 1 commit into from
Closed

Avoid infinate loops due to circular association referecnes. #789

wants to merge 1 commit into from

Conversation

ileitch
Copy link

@ileitch ileitch commented Jan 27, 2015

This commit fixes aSystemStackError which can arise in a situation such as this:

I have not tried with master.

class UserSerializer < AcitveModel::Serializer
  has_one :review
end

class ReviewSerializer < ActiveModel::Serializer
  has_one :user
end

@kurko
Copy link
Member

kurko commented Mar 19, 2015

Can someone using 0.9 review this?

@bf4 bf4 mentioned this pull request Jun 26, 2015
Merged
@bf4 bf4 mentioned this pull request Aug 24, 2015
Closed
@ileitch ileitch closed this Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S: Needs Code Review V: 0.9.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ileitch @kurko @joshsmith