Fixes nested has_many links in JSONAPI #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When linked resource had has_many links, all of them would use the association from the first resource, causing all of the items to build `links` with the same associations. This fixes it by iterating over the serializers, not just the attributes array.
| body: "Body", | ||
| id: "3", | ||
| links: { | ||
| comments: [], |
There was a problem hiding this comment.
The bug was here. Before, comments was ["1", "2"], not [].
|
Need a pair of eyes here @guilleiguaran @ggordon |
| @@ -58,25 +58,30 @@ def add_link(resource, name, serializer) | |||
| end | |||
| end | |||
|
|
|||
| def add_linked(resource_name, serializer, parent = nil) | |||
| def add_linked(resource_name, serializers, parent = nil) | |||
| serializers = Array(serializers) unless serializers.respond_to?(:each) | |||
There was a problem hiding this comment.
Is 'unless ...' needed here? If serializers is already an Array, Array(serializers) would just retunr serilizers.
There was a problem hiding this comment.
So, It can be Serializer or ArraySerializer. If it's Serializer, I convert to [Serializer] so I can treat them all equally, without the need for duplicating the logic, eg.
if serializer.respond_to?(:each)
serializer.each
do something
end
else
do something
endThere was a problem hiding this comment.
I see, Array(array_serializer) would be wrong.
|
LGTM 👍 |
kurko
added a commit
that referenced
this pull request
Nov 17, 2014
Fixes nested has_many links in JSONAPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linked resource had has_many links, all of them would use the
association from the first resource, causing all of the items to build
linkswith the same associations.This fixes it by iterating over the serializers, not just the
attributes array.