Updated isolated tests to assert correct behavior. #2010

akshah123 · 2016-12-21T20:35:40Z

Updated isolated tests to assert correct behavior and removed a test case that wasn't really testing anything.

Purpose

Tighten up some test cases

Changes

Fixed assertion criteria for test cases to look for correct behavior

Caveats

Removed test isn't really needed

Related GitHub issues

N/A

Additional helpful information

Removed a test case that wasn't really testing anything.

mention-bot · 2016-12-21T20:35:41Z

@akshah123, thanks for your PR! By analyzing the history of the files in this pull request, we identified @remear and @dubadub to be potential reviewers.

bf4 · 2016-12-21T21:15:15Z

rubocop

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:21:37: C: Style/SpaceInsideHashLiteralBraces: Space inside { missing. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)
      render jsonapi: post, fields: {posts: ['title']}
                                    ^
test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:21:54: C: Style/SpaceInsideHashLiteralBraces: Space inside } missing. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)
      render jsonapi: post, fields: {posts: ['title']}
                                                     ^
test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:104:18: C: Style/SpaceInsideHashLiteralBraces: Space inside { missing. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)
      expected = {'name' => 'Johnny Rico'}
                 ^
test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:104:42: C: Style/SpaceInsideHashLiteralBraces: Space inside } missing. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)
      expected = {'name' => 'Johnny Rico'}
                                         ^
test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:109:56: C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://github.com/bbatsov/ruby-style-guide#consistent-string-literals)
      assert_equal expected, JSON.parse(response.body)["data"]["attributes"] 
                                                       ^^^^^^
test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:109:64: C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://github.com/bbatsov/ruby-style-guide#consistent-string-literals)
      assert_equal expected, JSON.parse(response.body)["data"]["attributes"] 
                                                               ^^^^^^^^^^^^
test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:109:77: C: Style/TrailingWhitespace: Trailing whitespace detected. (https://github.com/bbatsov/ruby-style-guide#no-trailing-whitespace)
      assert_equal expected, JSON.parse(response.body)["data"]["attributes"] 
                                                                            ^
test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:113:18: C: Style/SpaceInsideHashLiteralBraces: Space inside { missing. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)
      expected = {'title'  => 'This is a test' }
                 ^
test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:113:28: C: Style/SpaceAroundOperators: Operator => should be surrounded by a single space. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)
      expected = {'title'  => 'This is a test' }
                           ^^
test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:117:56: C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://github.com/bbatsov/ruby-style-guide#consistent-string-literals)
      assert_equal expected, JSON.parse(response.body)["data"]["attributes"]
                                                       ^^^^^^
test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:117:64: C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://github.com/bbatsov/ruby-style-guide#consistent-string-literals)
      assert_equal expected, JSON.parse(response.body)["data"]["attributes"]
                                                               ^^^^^^^^^^^^

bf4

Thanks for this, I think you almost got it.

bf4 · 2016-12-21T21:18:26Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

-      payload = '{"data": {"attributes": {"name": "Johnny Rico"}, "type": "authors"}}'
-      headers = { 'CONTENT_TYPE' => 'application/vnd.api+json' }
-      post '/render_with_jsonapi_renderer', params: payload, headers: headers
-      assert expected, response.body


so, this should have raised an exception when hitting render_with_jsonapi_renderer which calls render jsonapi: json but there's no jsonapi renderer registered. good test to have

the problem is that it raises an exception while trying to create a new author since params are not parsed correctly without this. So, I can setup another api method.

I think i have a way to change controller to test this case. Let me take a shot.

@bf4 i can't get the test controller to return the actual exception. I tried using rescue_from but i think since the error is with render it just returns 500 with blank body.

I think for now, I am just going to assert that response.status = 500

bf4 · 2016-12-21T21:19:25Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

      payload = '{"data": {"attributes": {"name": "Johnny Rico"}, "type": "authors"}}'
      headers = { 'CONTENT_TYPE' => 'application/vnd.api+json' }
      post '/render_with_jsonapi_renderer', params: payload, headers: headers
-      assert expected, response.body
+      assert_equal expected, JSON.parse(response.body)["data"]["attributes"] 


why not just assert_equal expected, JSON.parse(respond.body)?

That was because actual response has tons of other things added to it like meta, relationships which was not part of this test and would break anytime a new element is added.

bf4 · 2016-12-21T21:20:19Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

+      payload = '{"data": {"attributes": {"title": "This is a test","body": "Of an emergency alert system."}, "type": "posts"},"fields": { "posts" : ["title"] } }'
+      headers = { 'CONTENT_TYPE' => 'application/vnd.api+json' }
+      post '/render_with_jsonapi_fields?fields[posts][]=title', params: payload, headers: headers
+      assert_equal expected, JSON.parse(response.body)["data"]["attributes"]


I don't think this test belongs here. (typo in name as well). This test appears to be testing usage of the jsonapi renderer, where all this file is doing is testing registering it, which is why it's isolated

good point. I will remove it.

…esponse status.

akshah123 · 2016-12-22T16:24:32Z

@bf4 I made requested changes. Let me know what you think about failure check.

bf4 · 2016-12-22T22:24:34Z

@akshah123

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:63:7: W: Lint/UselessAssignment: Useless assignment to variable - expected. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
      expected = {
      ^^^^^^^^
test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:68:9: C: Style/AlignHash: Align the elements of a hash literal if they span more than one line.
        'type' => 'authors'

:( did you check the CI failures?

bf4

Almost there! I just need some help understanding some of the changes that, on the surface, don't look related to fixing the expectation.

bf4 · 2016-12-22T22:25:18Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

@@ -12,7 +12,8 @@ class << self
    end

    def render_with_jsonapi_renderer
-      author = Author.new(params[:data][:attributes])
+      attributes = params[:data].present? ? params[:data][:attributes] : {}


why? how could this not be set and why would we want that fallback if not set?

this is because when adapter is not set as jsonapi, params are not set. This is there so that it fails on render and not on trying to set Author object. Since we use the same controller in case where it should succeed and fail, I wanted to make sure this part doesn't cause a failure.

bf4 · 2016-12-22T22:26:02Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

@@ -64,13 +65,13 @@ def test_jsonapi_renderer_not_registered
          'attributes' => {
            'name' => 'Johnny Rico'
          },
-          'type' => 'users'
+        'type' => 'authors'


why? type looks correct to me

I just wanted it to match what was being returned from controller. I don't have an issue with changing it back to "users" just thought that this way it would match.

bf4 · 2016-12-22T22:27:22Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

      payload = '{"data": {"attributes": {"name": "Johnny Rico"}, "type": "authors"}}'
      headers = { 'CONTENT_TYPE' => 'application/vnd.api+json' }
      post '/render_with_jsonapi_renderer', params: payload, headers: headers
-      assert expected, response.body
+      assert_equal expected, JSON.parse(response.body)['data']['attributes']


Why only checking part of response. did this fail when changing assert to assert_equal? perhaps should have be expected.to_json

it did fail. The problem is that response.body contains a lot of stuff then just data.attributes and type. It includes relationships, id and other things.

here is the actual response.body

{ "data": { "id": "author", "type": "authors", "attributes": { "name": "Johnny Rico" }, "relationships": { "posts": { "data": null }, "roles": { "data": null }, "bio": { "data": null } } } }

Oh, this is because of the PORO Author having relationships that are explicit now, whereas before they were sort of squishy...

Fix is we should be explicit what our model and serializer are:

class JsonApiRendererTest < ActionDispatch::IntegrationTest include ActiveSupport::Testing::Isolation class Author < ::Model attributes :name end class AuthorSerializer < ActiveModel::Serializer type: 'users' attribute :id attribute :name end

I think that's a better expectation, no?

i think so. But I can't get your code to work. The dependency required is getting a bit too much. For now, i have updated expected object to include all relationships so that we check for exact output.

bf4 · 2016-12-22T22:27:54Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

        }
      }
      payload = '{"data": {"attributes": {"name": "Johnny Rico"}, "type": "authors"}}'
      headers = { 'CONTENT_TYPE' => 'application/vnd.api+json' }
      post '/render_with_jsonapi_renderer', params: payload, headers: headers
-      assert expected, response.body
+      assert_equal 500, response.status


can we make an assertion about the nature of the failure by matching on the response.body?

I couldn't get response.body to show the exception. It kept returning empty body. I think this probably has something to do with it failing on render.

looks good.

can you add an assertion for the empty body?

If you know what the exception actually, was, would love for you to paste it and stack trace here.

actual exception message:

Missing template json_api_renderer_test/test/render_with_jsonapi_renderer with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby]}. Searched in:

backtrace

["test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:19:in `render_with_jsonapi_renderer'", "test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb:68:in `test_jsonapi_renderer_not_registered'"]

awesome! thanks!

…n of ruby.

…e to check.

akshah123 · 2016-12-23T16:25:12Z

@bf4 i have made some changes so that the tests pass. It took a while since i ran into issues with different versions of rails and had a hard time trying to reproduce the failing tests locally. I also made modification to check for exact exception when that information is available.

bf4

Thanks for much for your attention to this! A few small changes to make it a little more confident and less 'timid', as Avdi would say.

bf4 · 2016-12-23T17:29:11Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

      payload = '{"data": {"attributes": {"name": "Johnny Rico"}, "type": "authors"}}'
      headers = { 'CONTENT_TYPE' => 'application/vnd.api+json' }
      post '/render_with_jsonapi_renderer', params: payload, headers: headers
-      assert expected, response.body
+      assert_equal 500, response.status
+      assert response.request.env['action_dispatch.exception'].is_a?(ActionView::MissingTemplate) if response.request.present?


when is response.request.present? not true?

From what I can tell, it changes on a specific rails version. At some 4.x version, we start getting response.request but we dont' have that for 4.1.

bf4 · 2016-12-23T17:29:45Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

        }
      }
      payload = '{"data": {"attributes": {"name": "Johnny Rico"}, "type": "authors"}}'
      headers = { 'CONTENT_TYPE' => 'application/vnd.api+json' }
      post '/render_with_jsonapi_renderer', params: payload, headers: headers
-      assert expected, response.body
+      assert_equal 500, response.status


looks good.

can you add an assertion for the empty body?

If you know what the exception actually, was, would love for you to paste it and stack trace here.

bf4 · 2016-12-23T17:35:16Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

      payload = '{"data": {"attributes": {"name": "Johnny Rico"}, "type": "authors"}}'
      headers = { 'CONTENT_TYPE' => 'application/vnd.api+json' }
      post '/render_with_jsonapi_renderer', params: payload, headers: headers
-      assert expected, response.body
+      assert_equal expected, JSON.parse(response.body)['data']['attributes']


Oh, this is because of the PORO Author having relationships that are explicit now, whereas before they were sort of squishy...

Fix is we should be explicit what our model and serializer are:

class JsonApiRendererTest < ActionDispatch::IntegrationTest include ActiveSupport::Testing::Isolation class Author < ::Model attributes :name end class AuthorSerializer < ActiveModel::Serializer type: 'users' attribute :id attribute :name end

I think that's a better expectation, no?

bf4 · 2016-12-23T17:37:43Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

@@ -12,7 +12,9 @@ class << self
    end

    def render_with_jsonapi_renderer
-      author = Author.new(params[:data][:attributes])
+      unlocked_params = Rails::VERSION::MAJOR >= 5 ? params.to_unsafe_h : params
+      attributes = unlocked_params[:data].present? ? unlocked_params[:data][:attributes] : {}


So, I gather Author.new(params[:data][:attributes]) is failing for some reason. perhaps we should instead author = Author.new(params.require(:data).require(:attributes))? I'm not sure what the need is to cast the ActionController::Parameters or when data wouldn't be present.

In actual usage I would use the JsonApi deserializer here.

You are right that params[:data] is not set at all and the reason is that app doesn't know how to parse provided data.

.require will not help since it doesn't see data at all. Also, require will cause problem when jsonapi is not registered since it doesn't see the actual value.

oh, so params is {} ? Then that's probably still a good failure :)

akshah123 · 2016-12-23T23:43:22Z

@bf4 made some suggested changes. However, now the build is failing for something unrelated to my code. I can't reproduce this failure locally even with travis-ci's docker image. Do you have any idea on what I can do to get it passing?

bf4 · 2016-12-25T02:13:25Z

@akshah123 re: #2010 (comment) these failures are resolved on master. If you rebase, they should go away.

bf4

You've been working on this PR a while now, and the main goal of it is done. Thanks! I can do some of the other things I'd like in a followup :)

bf4 · 2016-12-25T02:14:49Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

@@ -12,7 +12,9 @@ class << self
    end

    def render_with_jsonapi_renderer
-      author = Author.new(params[:data][:attributes])
+      unlocked_params = Rails::VERSION::MAJOR >= 5 ? params.to_unsafe_h : params
+      attributes = unlocked_params[:data].present? ? unlocked_params[:data][:attributes] : {}


oh, so params is {} ? Then that's probably still a good failure :)

bf4 · 2016-12-25T02:16:46Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

+            'posts' => { 'data' => nil },
+            'roles' => { 'data' => nil },
+            'bio' => { 'data' => nil }
+          }


#2010 (comment)

bf4 · 2016-12-25T02:25:40Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

        }
      }
      payload = '{"data": {"attributes": {"name": "Johnny Rico"}, "type": "authors"}}'
      headers = { 'CONTENT_TYPE' => 'application/vnd.api+json' }
      post '/render_with_jsonapi_renderer', params: payload, headers: headers
-      assert expected, response.body
+      assert_equal 500, response.status


awesome! thanks!

bf4 · 2016-12-25T02:27:51Z

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

        }
      }
+
      payload = '{"data": {"attributes": {"name": "Johnny Rico"}, "type": "authors"}}'


I guess we should include a uuid here. how about "id": ""36c9c04e-86b1-4636-a5b0-8616672d1765" will make the expectation simpler. JSON API recommends that if a client wants to create an id on post, to use a uuid.

You've been working on this PR a while now, and the main goal of it is done. Thanks! I can do some of the other things I'd like in a followup :)

* Updated isolated tests to assert correct behavior. * Added check to get unsafe params if rails version is great than 5

* Merge pull request #1990 from mxie/mx-result-typo Fix typos and capitalization in Relationship Links docs [ci skip] * Merge pull request #1992 from ojiry/bump_ruby_versions Run tests by Ruby 2.2.6 and 2.3.3 * Merge pull request #1994 from bf4/promote_architecture Promote important architecture description that answers a lot of questions we get Conflicts: docs/ARCHITECTURE.md * Merge pull request #1999 from bf4/typos Fix typos [ci skip] * Merge pull request #2000 from berfarah/patch-1 Link to 0.10.3 tag instead of `master` branch * Merge pull request #2007 from bf4/check_ci Test was failing due to change in JSON exception message when parsing empty string * Swap out KeyTransform for CaseTransform (#1993) * delete KeyTransform, use CaseTransform * added changelog Conflicts: CHANGELOG.md * Merge pull request #2005 from kofronpi/support-ruby-2.4 Update jsonapi runtime dependency to 0.1.1.beta6 * Bump to v0.10.4 * Merge pull request #2018 from rails-api/bump_version Bump to v0.10.4 [ci skip] Conflicts: CHANGELOG.md * Merge pull request #2019 from bf4/fix_method_redefined_warning Fix AMS warnings * Merge pull request #2020 from bf4/silence_grape_warnings Silence Grape warnings * Merge pull request #2017 from bf4/remove_warnings Fix mt6 assert_nil warnings * Updated isolated tests to assert correct behavior. (#2010) * Updated isolated tests to assert correct behavior. * Added check to get unsafe params if rails version is great than 5 * Merge pull request #2012 from bf4/cleanup_isolated_jsonapi_renderer_tests_a_bit Cleanup assertions in isolated jsonapi renderer tests a bit * Add Model#attributes helper; make test attributes explicit * Fix model attributes accessors * Fix typos * Randomize testing of compatibility layer against regressions * Test bugfix * Add CHANGELOG * Merge pull request #1981 from groyoh/link_doc Fix relationship links doc Conflicts: CHANGELOG.md

* Updated isolated tests to assert correct behavior. * Added check to get unsafe params if rails version is great than 5

* Merge pull request rails-api#1990 from mxie/mx-result-typo Fix typos and capitalization in Relationship Links docs [ci skip] * Merge pull request rails-api#1992 from ojiry/bump_ruby_versions Run tests by Ruby 2.2.6 and 2.3.3 * Merge pull request rails-api#1994 from bf4/promote_architecture Promote important architecture description that answers a lot of questions we get Conflicts: docs/ARCHITECTURE.md * Merge pull request rails-api#1999 from bf4/typos Fix typos [ci skip] * Merge pull request rails-api#2000 from berfarah/patch-1 Link to 0.10.3 tag instead of `master` branch * Merge pull request rails-api#2007 from bf4/check_ci Test was failing due to change in JSON exception message when parsing empty string * Swap out KeyTransform for CaseTransform (rails-api#1993) * delete KeyTransform, use CaseTransform * added changelog Conflicts: CHANGELOG.md * Merge pull request rails-api#2005 from kofronpi/support-ruby-2.4 Update jsonapi runtime dependency to 0.1.1.beta6 * Bump to v0.10.4 * Merge pull request rails-api#2018 from rails-api/bump_version Bump to v0.10.4 [ci skip] Conflicts: CHANGELOG.md * Merge pull request rails-api#2019 from bf4/fix_method_redefined_warning Fix AMS warnings * Merge pull request rails-api#2020 from bf4/silence_grape_warnings Silence Grape warnings * Merge pull request rails-api#2017 from bf4/remove_warnings Fix mt6 assert_nil warnings * Updated isolated tests to assert correct behavior. (rails-api#2010) * Updated isolated tests to assert correct behavior. * Added check to get unsafe params if rails version is great than 5 * Merge pull request rails-api#2012 from bf4/cleanup_isolated_jsonapi_renderer_tests_a_bit Cleanup assertions in isolated jsonapi renderer tests a bit * Add Model#attributes helper; make test attributes explicit * Fix model attributes accessors * Fix typos * Randomize testing of compatibility layer against regressions * Test bugfix * Add CHANGELOG * Merge pull request rails-api#1981 from groyoh/link_doc Fix relationship links doc Conflicts: CHANGELOG.md

Updated isolated tests to assert correct behavior.

8d18374

Removed a test case that wasn't really testing anything.

bf4 requested changes Dec 21, 2016

View reviewed changes

akshah123 added 2 commits December 21, 2016 17:49

Made updates as requested. Added back failure test to check for 500 r…

921ffac

…esponse status.

Fixed whitespace issues.

baf58c7

bf4 requested changes Dec 22, 2016

View reviewed changes

akshah123 added 5 commits December 22, 2016 17:45

Removed unused parameter.

57a4fc2

Added log command so i can figure out why it's failing on some versio…

2debd58

…n of ruby.

Fixed up the tests so that it will pass with all version of rails.

b712de3

Fixed up the test so it only checks this condition when it is possibl…

377ea05

…e to check.

Added check to get unsafe params if rails version is great than 5

c4a27b2

bf4 requested changes Dec 23, 2016

View reviewed changes

akshah123 added 2 commits December 23, 2016 18:22

Changed the tests to be explicit about exact serialization response.

822e1b2

Removed require for pry

ffde106

bf4 approved these changes Dec 25, 2016

View reviewed changes

bf4 merged commit f246741 into rails-api:master Dec 25, 2016

bf4 mentioned this pull request Dec 25, 2016

Cleanup assertions in isolated jsonapi renderer tests a bit #2012

Merged

bf4 pushed a commit that referenced this pull request Jan 6, 2017

Updated isolated tests to assert correct behavior. (#2010)

3a88c39

* Updated isolated tests to assert correct behavior. * Added check to get unsafe params if rails version is great than 5

bf4 pushed a commit that referenced this pull request Jan 7, 2017

Updated isolated tests to assert correct behavior. (#2010)

59aed4d

* Updated isolated tests to assert correct behavior. * Added check to get unsafe params if rails version is great than 5

Updated isolated tests to assert correct behavior. #2010

Updated isolated tests to assert correct behavior. #2010

Conversation

akshah123 commented Dec 21, 2016

Purpose

Changes

Caveats

Related GitHub issues

Additional helpful information

mention-bot commented Dec 21, 2016

bf4 commented Dec 21, 2016

bf4 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akshah123 commented Dec 22, 2016

bf4 commented Dec 22, 2016

bf4 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akshah123 Dec 22, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akshah123 commented Dec 23, 2016

bf4 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akshah123 commented Dec 23, 2016

bf4 commented Dec 25, 2016

bf4 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akshah123 Dec 22, 2016 •

edited

Loading