Update README to write how to configure adapter #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,6 +96,12 @@ Thanks! | |||
|
|
|||
| ## High-level behavior | |||
|
|
|||
| Choise an adapter from [adapters](lib/active_model/serializer/adapter): | |||
There was a problem hiding this comment.
Choise should be Choose.
There was a problem hiding this comment.
Good catch @NullVoxPopuli !
I fixed it 🔧 90cfa92
|
I'm surprised that wasn't already on that document. nice catch! |
tricknotes
force-pushed
the
how-to-configure-adapter
branch
from
8570d49 to
90cfa92
Compare
| @@ -96,6 +96,12 @@ Thanks! | |||
|
|
|||
| ## High-level behavior | |||
|
|
|||
| Choose an adapter from [adapters](lib/active_model/serializer/adapter): | |||
There was a problem hiding this comment.
Adapters have been migrated to lib/active_model_serializers/adapter IIRC.
There was a problem hiding this comment.
Ouch! That's right.
tricknotes
force-pushed
the
how-to-configure-adapter
branch
from
90cfa92 to
dfd9cf9
Compare
|
LGTM, @tricknotes, thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the new user, how to customize adapter is an important concern.
Additionally, README says:
However how to change adapter was not documented anywhere.