Fix appveyor setting for JRuby #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's funny how many times we need to fix things just to get appveyor happy.. :-\ |
Path for JRuby is not correct so tests run on CRuby 1.9 till now...
mtsmfm
force-pushed
the
fix-appveyor-setting-for-jruby
branch
from
c3275f3 to
d9eac2a
Compare
|
LGTM, I'll merge unless @bf4 has concerns 🎉 |
| - ruby_version: "jruby-9.0.4.0" | ||
| - ruby_version: "Ruby21" | ||
| - ruby_version: "Ruby21-x64" | ||
| - ruby_version: "jruby-9.0.0.0" |
There was a problem hiding this comment.
why are we lowering the Jruby version? and putting the JRUBY_OPTS globally?
There was a problem hiding this comment.
Only available jruby-9.0.0.0 on appveyor:
https://ci.appveyor.com/project/mtsmfm/active-model-serializers/build/1
putting the JRUBY_OPTS globally?
Yeah, I went same way for travis but it is not smart 😕
https://github.com/rails-api/active_model_serializers/blob/master/.travis.yml#L25-L26
Should I apply patch for that on this PR or create another PR?
|
I have questions, but am ok merging to that we can get green and then revisit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: #1699 (comment)
Path for JRuby is not correct so tests run on CRuby 1.9 till now...