Properly deserialize dasherized keys #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON API adapater dasherizes every key, but the deserializer left the keys unaltered. Thus, the client had to send underscored keys in the request body in order for Rails to properly match sent values to model attributes. This commit adds automatic key transformation on deserialization. Per default the deserializer transforms the keys to underscore, but this behaviour can also be changed by including `key_transform` in the deserializer options.
lawitschka
force-pushed
the
key-transform-on-deserialization
branch
from
1e9d4fc to
afe786d
Compare
| @@ -182,23 +182,29 @@ def parse_relationship(assoc_name, assoc_data, options) | |||
| prefix_key = field_key(assoc_name, options).to_s.singularize | |||
| hash = | |||
| if assoc_data.is_a?(Array) | |||
| { "#{prefix_key}_ids".to_sym => assoc_data.map { |ri| ri['id'] } } | |||
| { "#{prefix_key}_ids".to_sym => assoc_data.map { |ri| ri[:id] } } | |||
There was a problem hiding this comment.
because KeyTransform#underscore (and every other method in KeyTransform) transforms all keys to symbols, so string key access does not work here
There was a problem hiding this comment.
Just FYI, this is likely going to change very soon. I've been altering the transform stuff to be more flexible. Stay tuned for that.
|
I'm good with this, anybody ele,? I'd like. To getiit merged |
|
Seems good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The JSON API adapater dasherizes every key, but the deserializer left the keys
unaltered. Thus, the client had to send underscored keys in the request body in
order for Rails to properly match sent values to model attributes.
The changes make overwriting
keyForAttribute()andkeyForRelationship()inEmber.js apps obselete, because Active Model Serializer properly deserializes
the request.
Changes
This commit adds automatic key transformation on deserialization. Per default the
deserializer transforms the keys to underscore, but this behaviour can also be
changed by including
key_transformin the deserializer options.Caveats
I did not include tests for the
KeyTransform#underscore, because the tests forkey transform only tested the transformation in controller context.
Related GitHub issues
#1612