Fix warnings #1620
Merged
Fix warnings #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the Rails routes are broken. |
| module TestHelper | ||
| Routes = ActionDispatch::Routing::RouteSet.new |
There was a problem hiding this comment.
Tried it out locally, seems like removing this broke the routes.
|
The routes and grape warning are still quite annoying. Looking forward to get rid of them. Good job! |
|
I have a fix for routes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI output needs to be reviewed.
I'm also trying to figure out which tests cause
lib/action_dispatch/routing/route_set.rb:429: warning: instance variable @_routes not initializedand why.
gems/grape-0.15.0/lib/grapeAlso: